Skip to content

Update requirements.txt#7

Open
oxysoft wants to merge 1 commit intoadefossez:mainfrom
oxysoft:patch-1
Open

Update requirements.txt#7
oxysoft wants to merge 1 commit intoadefossez:mainfrom
oxysoft:patch-1

Conversation

@oxysoft
Copy link
Copy Markdown

@oxysoft oxysoft commented Jul 15, 2024

Support latest version of torchaudio (already functional with no changes)

Support latest version of torchaudio (already functional with no changes)
@oxysoft
Copy link
Copy Markdown
Author

oxysoft commented Jul 15, 2024

I had some problems using demucs in my project / cloud compute which uses torch 2.3.1, however I have updated all the libraries 2.3.1 and kept demucs and it's working just fine. Not all features have been tested, so keep that in mind

@CarlGao4
Copy link
Copy Markdown

Actually, the global backend selector has been completely removed since torchaudio 2.2. Users can't switch audio backend when separating, so the separation won't be affected using torchaudio 2.2+. However, training requires this feature or passing the desire audio backend would make the code mess. Besides, deciding how to specify the backend according to torchaudio version will make the logic even complex, so I think limiting torchaudio versions to below 2.2 is a good choice.

Copy link
Copy Markdown

@str-it str-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. could not install without that fix

@samuelbradshaw
Copy link
Copy Markdown

If I'm understanding the README correctly, requirements.txt is the requirements file for training, and requirements_minimal.txt is the requirements file for simple stem separation. If training requires torchaudio<2.2, then requirements.txt can't be safely updated. But it should be safe to update requirements_minimal.txt. I opened a new pull request for this: #9

@ROBERT-MCDOWELL
Copy link
Copy Markdown

I'm using demucs with torch 2.7.1 and seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants