Loosen torchaudio version in requirements_minimal.txt - #9
Open
samuelbradshaw wants to merge 2 commits into
Open
Conversation
gselgiReply
added a commit
to gselgiReply/demucs
that referenced
this pull request
Sep 12, 2025
Da suggerimento adefossez#9
|
Yep, this works great for inference. |
|
I wonder if >2.9 might cause problems? in environment: however Important: the default model was recently changed to `htdemucs` the latest Hybrid Transformer Demucs model. In some cases, this model can actually perform worse than previous models. To get back the old default model use `-n mdx_extra_q`.
Selected model is a bag of 1 models. You will see that many progress bars per track.
Separated tracks will be stored in /home/dave/separated/htdemucs
Namespace(tracks=[PosixPath('/home/dave/Development/stems/tmp.wav')], sig=None, name='htdemucs', repo=None, verbose=False, out=PosixPath('separated'), filename='{track}/{stem}.{ext}', device='cuda', shifts=1, overlap=0.25, split=True, segment=None, stem=None, int24=False, float32=False, clip_mode='rescale', flac=False, mp3=False, mp3_bitrate=320, mp3_preset=2, jobs=0)
Separating track /home/dave/Development/stems/tmp.wav
100%|██████████████████████████████████████████████████████████████████████| 204.75/204.75 [00:08<00:00, 25.11seconds/s]
/home/dave/.local/share/uv/tools/demucs/lib/python3.12/site-packages/torchaudio/_backend/utils.py:337: UserWarning: In 2.9, this function's implementation will be changed to use torchaudio.save_with_torchcodec` under the hood. Some parameters like format, encoding, bits_per_sample, buffer_size, and ``backend`` will be ignored. We recommend that you port your code to rely directly on TorchCodec's encoder instead: https://docs.pytorch.org/torchcodec/stable/generated/torchcodec.encoders.AudioEncoder
warnings.warn(
/home/dave/.local/share/uv/tools/demucs/lib/python3.12/site-packages/torchaudio/_backend/ffmpeg.py:247: UserWarning: torio.io._streaming_media_encoder.StreamingMediaEncoder has been deprecated. This deprecation is part of a large refactoring effort to transition TorchAudio into a maintenance phase. The decoding and encoding capabilities of PyTorch for both audio and video are being consolidated into TorchCodec. Please see https://github.com/pytorch/audio/issues/3902 for more information. It will be removed from the 2.9 release.
s = torchaudio.io.StreamWriter(uri, format=muxer, buffer_size=buffer_size)in environment: Output completed though and audio separation seemed successful with 4 decent outputs |
Author
|
Thanks! I updated this pull request to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This pull request loosens the dependency version for
torchaudioinrequirements_minimal.txt.If I understand the README correctly, there are two sets of dependencies:
requirements_minimal.txtfor simple stem separation. This is what's used when installing viapip install demucs.requirements.txtorenvironment-[cpu|cuda].yml. This is for training.Training requires torchaudio<2.2, but stem separation appears to work correctly with later versions of torchaudio (see #7). Therefore, I think the dependencies in
requirements_minimal.txtcan be safely loosened to allow later torchaudio versions. I have tested stem separation with torchaudio 2.8.0 and everything appears to work correctly.