feat: add timed docs to top nav #570
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitanOmar
force-pushed
the
Add-Timed-Docs-To-Top-Nav
branch
2 times, most recently
from
2f4a26f to
f15114a
Compare
MitanOmar
force-pushed
the
Add-Timed-Docs-To-Top-Nav
branch
from
f15114a to
13f9bdc
Compare
c0rydoras
requested changes
Jan 9, 2025
MitanOmar
force-pushed
the
Add-Timed-Docs-To-Top-Nav
branch
from
13f9bdc to
a4385aa
Compare
MitanOmar
force-pushed
the
Add-Timed-Docs-To-Top-Nav
branch
from
a4385aa to
18c6207
Compare
c0rydoras
requested changes
Jan 20, 2025
c0rydoras
requested changes
Mar 20, 2025
MitanOmar
force-pushed
the
Add-Timed-Docs-To-Top-Nav
branch
from
f4a2ffd to
d342948
Compare
MitanOmar
force-pushed
the
Add-Timed-Docs-To-Top-Nav
branch
4 times, most recently
from
b887296 to
88a69ad
Compare
MitanOmar
force-pushed
the
Add-Timed-Docs-To-Top-Nav
branch
from
88a69ad to
593b203
Compare
|
@c0rydoras anything else ? |
c0rydoras
requested changes
Mar 24, 2025
c0rydoras
requested changes
Mar 24, 2025
MitanOmar
force-pushed
the
Add-Timed-Docs-To-Top-Nav
branch
from
9d53d35 to
f82a919
Compare
derrabauke
reviewed
Apr 9, 2025
|
|
derrabauke
reviewed
Apr 10, 2025
derrabauke
reviewed
Apr 10, 2025
c0rydoras
requested changes
Apr 23, 2025
Comment on lines
20
to
28
| const routes = { | ||
| "/attendances": "tracking/attendances", | ||
| "/reports": "tracking/timesheet", | ||
| "/analysis": "analysis", | ||
| "/statistics": "statistics", | ||
| "/projects": "projects", | ||
| "/users": "users", | ||
| "/": "tracking/activities", | ||
| }; |
There was a problem hiding this comment.
you could import these from the service, that way we have less redundancy (you'll have to export ROUTE_DOCS_MAPPING for that)
frontend/app/services/docs.js
Outdated
| } | ||
|
|
||
| get docsURL() { | ||
| return ROUTE_DOCS_MAPPING[this.router.currentRouteName] || ""; |
There was a problem hiding this comment.
nitpick
Suggested change
| return ROUTE_DOCS_MAPPING[this.router.currentRouteName] || ""; | |
| return ROUTE_DOCS_MAPPING[this.router.currentRouteName] ?? ""; |
MitanOmar
force-pushed
the
Add-Timed-Docs-To-Top-Nav
branch
from
a45a15b to
d928843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.