fix(arhcived-project-tasks): only superuser can edit tasks of archived projects #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the project is not archived
MitanOmar
force-pushed
the
stop-updating-or-adding-tasks-to-an-archived-project
branch
from
d8ec624 to
44db493
Compare
trowik
requested changes
Mar 24, 2025
backend/timed/permissions.py
Outdated
| @@ -65,6 +65,13 @@ def has_object_permission(self, request, view, _obj): | |||
| return self.has_permission(request, view) | |||
|
|
|||
|
|
|||
| class IsProjectActive(BasePermission): | |||
| """Allow Only the project that is not archived.""" | |||
There was a problem hiding this comment.
Suggested change
| """Allow Only the project that is not archived.""" | |
| """Allows access to object only if a project is not archived.""" |
backend/timed/projects/views.py
Outdated
Comment on lines
181
to
184
| # only superuser can update tasks of archived projects | ||
| | (IsUpdateOnly & IsProjectActive) | ||
| # managers may edit all tasks | ||
| | IsManager |
There was a problem hiding this comment.
The order is wrong!
This means that anyone who isn't a superuser can update a task if the project is active.
There was a problem hiding this comment.
Right - and wrong. It's not the order, but the full expression for the permission
Suggested change
| # only superuser can update tasks of archived projects | |
| | (IsUpdateOnly & IsProjectActive) | |
| # managers may edit all tasks | |
| | IsManager | |
| # only superuser can update tasks of archived projects | |
| | (IsUpdateOnly & IsProjectActive & IsManager) |
MitanOmar
force-pushed
the
stop-updating-or-adding-tasks-to-an-archived-project
branch
from
442b694 to
e50fd22
Compare
|
the backend tests is failing not because of this PR, and the fix will be #669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #513