WIP: fix(backend-test): the validation should not return None #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitanOmar
changed the title
winged
requested changes
Apr 10, 2025
| @@ -184,7 +184,7 @@ def validate(self, data): | |||
| .exists() | |||
| ): | |||
| return data | |||
| msg = "You don't have the permission to update this task" | |||
| msg = "You don't have the permission to update this task" # pragma: no cover | |||
There was a problem hiding this comment.
I'd rather see a test for this instead
There was a problem hiding this comment.
@winged i did not see tests in the beginning, that's why i did not wrote it, but for sure i can add,
and an important note: i see in the changes tab that the changes are only one file, but if you check f0785a2 commit, you will see that there are some snapshot updated, i would like to confirm this too please
There was a problem hiding this comment.
It's a change in behaviour, so I think there should be a test for it.
Regarding that commit, I think it's coming from the main branch as you merged main into this feature branch, so that's normal. Maybe try rebasing, then the diff should be less confusing
|
Just a couple questions:
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.