Conversation
Co-authored-by: afranken <763000+afranken@users.noreply.github.com>
…ills Co-authored-by: afranken <763000+afranken@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR establishes cross-references between Claude skills to create a cohesive workflow where skills invoke each other rather than operating in isolation. The changes address the problem where the implement skill would run without triggering follow-up tasks like testing, documentation, or refactoring, leading to incomplete feature work.
Changes:
- Added a 4-step workflow to
implementskill: refactor → implement → test → document - Extended
testandreviewskills with guidance to invokerefactorwhen encountering structural problems - Added blockquotes emphasizing preference for refactoring over workarounds
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.claude/skills/implement/SKILL.md |
Added "Skill Workflow" section with 4-step sequence, converted checklist items to explicit skill invocations, added blockquote guidance to prefer refactoring over workarounds |
.claude/skills/test/SKILL.md |
Added checklist item to invoke refactor skill when existing tests have structural problems |
.claude/skills/review/SKILL.md |
Extended "Should fix" category to recommend refactor skill for readability/style improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.claude/skills/implement/SKILL.md
Outdated
|
|
||
| A complete feature implementation requires these skills — run them in sequence: | ||
|
|
||
| 1. **refactor** skill — if nearby existing code, tests, or configuration would benefit from cleanup *before* adding new code, do it first rather than working around it |
There was a problem hiding this comment.
Inconsistent formatting: the skill name should be formatted as refactor (bold with backticks) to match the formatting used in lines 36-37 and in other skill files. Currently it's formatted as refactor (bold without backticks).
| 1. **refactor** skill — if nearby existing code, tests, or configuration would benefit from cleanup *before* adding new code, do it first rather than working around it | |
| 1. **`refactor`** skill — if nearby existing code, tests, or configuration would benefit from cleanup *before* adding new code, do it first rather than working around it |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Skills were siloed —
implementran in isolation without triggeringtest,document, orrefactor, leading to incomplete feature work and agents piling on workarounds instead of cleaning up existing code.Changes
implement/SKILL.mdrefactor(pre-flight cleanup) →implement→test→documentrefactorover adding complexity to work around existing codetest/SKILL.mdrefactorwhen existing tests have structural problems rather than working around themreview/SKILL.mdrefactorskill for purely readability/style findings — reviewers should direct torefactor, not ask for more code✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.