Replace stop/start with python-on-whales #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesliverx
reviewed
Oct 3, 2024
buildrunner/docker/runner.py
Outdated
| # start the container | ||
| self.container = self.docker_client.create_container(self.image_name, **kwargs) | ||
| self.docker_client.start(self.container["Id"]) | ||
| python_on_whales.docker.start(self.container["Id"]) |
Contributor
There was a problem hiding this comment.
Is this always used, even when not using the legacy builder?
Contributor
Author
There was a problem hiding this comment.
It is always used. Putting it in a conditional statement based on use_legacy_builder would be good idea though.
The name use_legacy_builder isn't the best name for this context. :)
bluesliverx
approved these changes
Oct 3, 2024
bluesliverx
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Previous Behavior
New Behavior
Merge requirements satisfied?
setup.py(if appropriate).