Skip to content

Replace stop/start with python-on-whales #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Replace stop/start with python-on-whales #165

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91434f4
Replace stop/start with python-on-whales
shanejbrown Oct 3, 2024
a9601b7
Add conditional statement for docker start/stop
shanejbrown Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions buildrunner/docker/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from docker.utils import compare_version
from retry import retry
import docker.errors
import python_on_whales
import six
import timeout_decorator

Expand Down Expand Up @@ -236,7 +237,7 @@ def start(

# start the container
self.container = self.docker_client.create_container(self.image_name, **kwargs)
self.docker_client.start(self.container["Id"])
python_on_whales.docker.start(self.container["Id"])
Copy link
Contributor

@bluesliverx bluesliverx Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always used, even when not using the legacy builder?

Copy link
Contributor Author

@shanejbrown shanejbrown Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is always used. Putting it in a conditional statement based on use_legacy_builder would be good idea though.

The name use_legacy_builder isn't the best name for this context. :)


# run any supplied provisioners
if provisioners:
Expand All @@ -254,10 +255,7 @@ def stop(self):
Stop the backing Docker container.
"""
if self.container:
self.docker_client.stop(
self.container["Id"],
timeout=0,
)
python_on_whales.docker.stop(self.container["Id"], time=0)

def cleanup(self):
"""
Expand Down
Loading