fix(esbuild): avoid using createRequire as import name
#799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominique-pfister
changed the title
createRequire as import name
Comment on lines
+171
to
+177
| it('generates the bundle (esm, esbuild)', async () => { | ||
| await generate(['--bundler=esbuild', '--esm'], PROJECT_SIMPLE_ESM); | ||
| }); | ||
|
|
||
| it('generates the bundle (esbuild) fails', async () => { | ||
| await assert.rejects(generate(['--bundler=esbuild']), Error('ESBuild bundler only supports ESM builds.')); | ||
| }); |
There was a problem hiding this comment.
finally added tests for esbuild bundler
|
This PR will trigger a patch release when merged. |
tripodsan
approved these changes
Apr 10, 2025
adobe-bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
## [12.4.31](v12.4.30...v12.4.31) (2025-04-10) ### Bug Fixes * **esbuild:** avoid using `createRequire` as import name ([#799](#799)) ([082551d](082551d))
|
🎉 This PR is included in version 12.4.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #798