chore: update disabledBehavior style for S2 TreeView
#9472
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| [ActionButtonGroupContext, {styles: treeActions, isDisabled}], | ||
| [ActionMenuContext, {styles: treeActionMenu, isQuiet: true, isDisabled}] |
There was a problem hiding this comment.
i think these should only be disabled if the disabledBehaviour is 'all', not just if the item is disabled
There was a problem hiding this comment.
isDisabled here comes from TreeState which determines isDisabled from a variety of different things. isDisabled will be false if disabledBehavior is selection
react-spectrum/packages/@react-stately/selection/src/SelectionManager.ts
Lines 504 to 506 in 76f539b
There was a problem hiding this comment.
ah, that was really hidden up there, thanks.
can you write a test for this? seems easy to accidentally regress on this one
| }); | ||
| }, | ||
| renderers: { | ||
| // todo - we don't support isDisabled on TreeViewItems? |
There was a problem hiding this comment.
this was a comment left by Rob when TreeView was first implemented in S2...not sure if this is relevant anymore? we support isDisabled on TreeViewItems according to the docs
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:CellRenderProps CellRenderProps {
- colIndex?: number | null
id?: Key
isFocusVisible: boolean
isFocused: boolean
isHovered: boolean
isSelected: boolean
}@react-aria/interactions/@react-aria/interactions:useFocusVisibleListener useFocusVisibleListener {
fn: FocusVisibleHandler
deps: ReadonlyArray<any>
opts?: {
- enabled?: boolean
- isTextInput?: boolean
+ isTextInput?: boolean
}
returnVal: undefined
}@react-spectrum/s2/@react-spectrum/s2:MenuSection MenuSection <T extends {}> {
aria-label?: string
- children?: ReactNode | (T) => ReactElement
+ children?: ReactNode
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
items?: Iterable<T>
onSelectionChange?: (Selection) => void
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
shouldCloseOnSelect?: boolean
value?: T
}/@react-spectrum/s2:MenuSectionProps MenuSectionProps <T extends {}> {
aria-label?: string
- children?: ReactNode | (T) => ReactElement
+ children?: ReactNode
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
items?: Iterable<T>
onSelectionChange?: (Selection) => void
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
shouldCloseOnSelect?: boolean
value?: T
} |
| TreeViewItemContent | ||
| } from '../src'; | ||
|
|
||
| AriaTreeTests({ |
There was a problem hiding this comment.
why are we deleting this file?
There was a problem hiding this comment.
nevermind, i see it's a rename
| let menu = queryByRole('menu'); | ||
| expect(menu).not.toBeInTheDocument(); |
There was a problem hiding this comment.
is menu === null here?
not.toBeInTheDocument is a bit of a weird assertion for that, but i guess it works 🤷🏻
There was a problem hiding this comment.
yeah ig i could change it to expect(menu).toBeNull()?
chromatic: https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=1101
make sure it matches the new proposed changes: RSP Component Milestones (view)
✅ Pull Request Checklist:
📝 Test Instructions:
Go to S2 storybook -> TreeView -> mess around with the disabledBehavior control
🧢 Your Project: