Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(textfield): update border and background color #3505

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix(textfield): update border and background color #3505

merged 2 commits into from
Jan 22, 2025

Conversation

TarunAdobe
Copy link
Contributor

@TarunAdobe TarunAdobe commented Jan 16, 2025 •
edited
Loading

Description

This PR addresses SWC-574 and updates the textfield border radius and background-color and adds the respective --mod property.

Validation steps

  1. Open the storybook for the textfield component:
    • Verify the correct background color and border color for Default, Hover, Focus Hover and Disabled state.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe force-pushed the s2-foundations-redux branch 3 times, most recently from 3114d29 to 246fa4d Compare January 17, 2025 03:36
@TarunAdobe TarunAdobe changed the title chore(textfield): update border and background color fix(textfield): update border and background color Jan 17, 2025
@TarunAdobe TarunAdobe marked this pull request as ready for review January 17, 2025 05:25
@castastrophe
feat: migration of tokens to spectrum 2
049c748 
Expanding the existing themes system to support the new S2 mappings.

---
Co-authored-by: castastrophe <[email protected]>
Co-authored-by: Patrick Fulton <[email protected]>
Co-authored-by: Cory Dransfeldt <[email protected]>
Co-authored-by: Aziz Ramos <[email protected]>
Co-authored-by: Josh Winn <[email protected]>
Co-authored-by: Rise Erpelding <[email protected]>
Co-authored-by: Marissa Huysentruyt <[email protected]>
Co-authored-by: Rajdeep Chandra <[email protected]>
Co-authored-by: TarunAdobe <[email protected]>
Co-authored-by: Dragan Eror<[email protected]>
@castastrophe castastrophe force-pushed the ttomar/swc-574 branch 2 times, most recently from 3e6e2b6 to dd6de73 Compare January 22, 2025 02:23
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 79b83ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/textfield Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@castastrophe castastrophe merged commit 84cd8ea into s2-foundations-redux Jan 22, 2025
1 check passed
@castastrophe castastrophe deleted the ttomar/swc-574 branch January 22, 2025 02:35
@marissahuysentruyt marissahuysentruyt mentioned this pull request Jan 22, 2025
Closed
9 tasks
castastrophe added a commit that referenced this pull request Jan 22, 2025
@TarunAdobe @castastrophe
fix(textfield): update border and background color (#3505)
d8d80a2 
* feat: migration of tokens to spectrum 2
Expanding the existing themes system to support the new S2 mappings.

---
Co-authored-by: castastrophe <[email protected]>
Co-authored-by: Patrick Fulton <[email protected]>
Co-authored-by: Cory Dransfeldt <[email protected]>
Co-authored-by: Aziz Ramos <[email protected]>
Co-authored-by: Josh Winn <[email protected]>
Co-authored-by: Rise Erpelding <[email protected]>
Co-authored-by: Marissa Huysentruyt <[email protected]>
Co-authored-by: Rajdeep Chandra <[email protected]>
Co-authored-by: TarunAdobe <[email protected]>
Co-authored-by: Dragan Eror<[email protected]>

* chore(textfield): update border and background color

---------

Co-authored-by: [ Cassondra ] <[email protected]>
castastrophe added a commit that referenced this pull request Jan 22, 2025
@TarunAdobe @castastrophe
fix(textfield): update border and background color (#3505)
6305b99 
* feat: migration of tokens to spectrum 2
Expanding the existing themes system to support the new S2 mappings.

---
Co-authored-by: castastrophe <[email protected]>
Co-authored-by: Patrick Fulton <[email protected]>
Co-authored-by: Cory Dransfeldt <[email protected]>
Co-authored-by: Aziz Ramos <[email protected]>
Co-authored-by: Josh Winn <[email protected]>
Co-authored-by: Rise Erpelding <[email protected]>
Co-authored-by: Marissa Huysentruyt <[email protected]>
Co-authored-by: Rajdeep Chandra <[email protected]>
Co-authored-by: TarunAdobe <[email protected]>
Co-authored-by: Dragan Eror<[email protected]>

* chore(textfield): update border and background color

---------

Co-authored-by: [ Cassondra ] <[email protected]>
castastrophe added a commit that referenced this pull request Jan 22, 2025
@TarunAdobe @castastrophe
fix(textfield): update border and background color (#3505)
d4c3069 
* feat: migration of tokens to spectrum 2
Expanding the existing themes system to support the new S2 mappings.

---
Co-authored-by: castastrophe <[email protected]>
Co-authored-by: Patrick Fulton <[email protected]>
Co-authored-by: Cory Dransfeldt <[email protected]>
Co-authored-by: Aziz Ramos <[email protected]>
Co-authored-by: Josh Winn <[email protected]>
Co-authored-by: Rise Erpelding <[email protected]>
Co-authored-by: Marissa Huysentruyt <[email protected]>
Co-authored-by: Rajdeep Chandra <[email protected]>
Co-authored-by: TarunAdobe <[email protected]>
Co-authored-by: Dragan Eror<[email protected]>

* chore(textfield): update border and background color

---------

Co-authored-by: [ Cassondra ] <[email protected]>
castastrophe added a commit that referenced this pull request Jan 23, 2025
@TarunAdobe @castastrophe
fix(textfield): update border and background color (#3505)
c684c80 
* feat: migration of tokens to spectrum 2
Expanding the existing themes system to support the new S2 mappings.

---
Co-authored-by: castastrophe <[email protected]>
Co-authored-by: Patrick Fulton <[email protected]>
Co-authored-by: Cory Dransfeldt <[email protected]>
Co-authored-by: Aziz Ramos <[email protected]>
Co-authored-by: Josh Winn <[email protected]>
Co-authored-by: Rise Erpelding <[email protected]>
Co-authored-by: Marissa Huysentruyt <[email protected]>
Co-authored-by: Rajdeep Chandra <[email protected]>
Co-authored-by: TarunAdobe <[email protected]>
Co-authored-by: Dragan Eror<[email protected]>

* chore(textfield): update border and background color

---------

Co-authored-by: [ Cassondra ] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TarunAdobe @castastrophe