Skip to content

chore: lock playwright version [swc-829] #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: lock playwright version [swc-829] #5414

wants to merge 1 commit into from

Conversation

castastrophe
Copy link
Collaborator

Description

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this

  • Test case 2

    1. Go here
    2. Do this

  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d256457

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@castastrophe castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch from 05d38b3 to d1f97c0 Compare April 29, 2025 15:52
@github-actions GitHub Actions
Copy link

Tachometer results

Currently, no packages are changed by this PR...

@castastrophe castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch 6 times, most recently from 16ac9a1 to f28b5e9 Compare April 29, 2025 17:06
castastrophe
castastrophe commented Apr 29, 2025
View reviewed changes
packages/number-field/test/inputs.test.ts
@@ -28,23 +27,6 @@ import {
import { sendKeys } from '@web/test-runner-commands';

describe('NumberField - inputs', () => {
before(async () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CanIUse indicates that the international number field has been available in our supported evergreen - 2 so we can remove the polyfills now

castastrophe
castastrophe commented Apr 29, 2025
View reviewed changes
tools/reactive-controllers/src/LanguageResolution.ts
@@ -19,7 +19,18 @@ export const languageResolverUpdatedSymbol = Symbol(

export class LanguageResolutionController implements ReactiveController {
private host: ReactiveElement;
language = document.documentElement.lang || navigator.language;
get language(): string {
return document.documentElement.lang || navigator.language;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fetching the root-level language but shouldn't we also be honoring if the language attribute is set on a container too?

@castastrophe castastrophe force-pushed the castastrophe/swc-829-playwright-lock branch from f28b5e9 to d256457 Compare May 5, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@castastrophe