chore: lock playwright version [swc-829] #5414
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -115,6 +115,7 @@ | |
| } | ||
| ], | ||
| "import/prefer-default-export": "off", | ||
| "import/no-extraneous-dependencies": "off", | ||
| "lit-a11y/click-events-have-key-events": [ | ||
| "error", | ||
| { | ||
|
|
@@ -153,5 +154,41 @@ | |
| "ignoreMemberSort": false | ||
| } | ||
| ] | ||
| }, | ||
| "extends": [ | ||
|
Contributor
There was a problem hiding this comment. 🚫 [eslint] <no-dupe-keys> reported by reviewdog 🐶 |
||
| "eslint:recommended", | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:prettier/recommended", | ||
| "plugin:lit-a11y/recommended", | ||
| "plugin:require-extensions/recommended" | ||
| ], | ||
| "overrides": [ | ||
|
Contributor
There was a problem hiding this comment. 🚫 [eslint] <no-dupe-keys> reported by reviewdog 🐶 |
||
| { | ||
| "files": ["scripts/*"], | ||
| "rules": { | ||
| "no-console": ["off"] | ||
| } | ||
| }, | ||
| { | ||
| "files": [ | ||
| "packages/*/src/*.ts", | ||
| "tools/*/src/*.ts", | ||
| "projects/*/src/*.ts" | ||
| ], | ||
| "rules": { | ||
| "import/no-extraneous-dependencies": [ | ||
| "error", | ||
| { | ||
| "devDependencies": true | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "files": ["react/**/*.ts"], | ||
| "rules": { | ||
| "@typescript-eslint/no-explicit-any": "off" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. 🚫 [eslint] <notice/notice> reported by reviewdog 🐶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ import prettier from 'prettier'; | |
| import Case from 'case'; | ||
|
Contributor
There was a problem hiding this comment. 🚫 [eslint] <import/no-extraneous-dependencies> reported by reviewdog 🐶 |
||
| import { fileURLToPath } from 'url'; | ||
|
|
||
| import systemsIconMapping from './icons-mapping.json' with { type: 'json' }; | ||
|
|
||
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
|
|
||
|
|
@@ -169,9 +169,9 @@ async function buildIcons(icons, tag, iconsNameList) { | |
|
|
||
| const iconLiteral = ` | ||
| ${disclaimer} | ||
|
|
||
| import {tag as html, TemplateResult} from '../custom-tag.js'; | ||
|
|
||
| export {setCustomTemplateLiteralTag} from '../custom-tag.js'; | ||
| export const ${ComponentName}Icon = ({ | ||
| width = 24, | ||
|
|
@@ -241,7 +241,7 @@ async function buildIcons(icons, tag, iconsNameList) { | |
|
|
||
| const iconElement = ` | ||
| ${disclaimer} | ||
|
|
||
| import { | ||
| html, | ||
| TemplateResult | ||
|
|
@@ -252,22 +252,22 @@ async function buildIcons(icons, tag, iconsNameList) { | |
| import { | ||
| setCustomTemplateLiteralTag | ||
| } from '../custom-tag.js'; | ||
|
|
||
| ${currenVersionIconImport} | ||
| ${otherVersionIconImport} | ||
|
|
||
| /** | ||
| * @element ${iconElementName} | ||
| */ | ||
| export class Icon${ComponentName} extends IconBase { | ||
| protected override render(): TemplateResult { | ||
| setCustomTemplateLiteralTag(html); | ||
|
|
||
| if(this.spectrumVersion === ${spectrumVersion}){ | ||
| return CurrentIcon({ hidden: !this.label, title: this.label }) as TemplateResult; | ||
| } | ||
| return AlternateIcon({ hidden: !this.label, title: this.label }) as TemplateResult; | ||
|
|
||
| } | ||
| } | ||
| `; | ||
|
|
@@ -302,12 +302,12 @@ async function buildIcons(icons, tag, iconsNameList) { | |
|
|
||
| const iconRegistration = ` | ||
| ${disclaimer} | ||
|
|
||
| import { Icon${ComponentName} } from '../src/elements/Icon${id}.js'; | ||
| import { defineElement } from '@spectrum-web-components/base/src/define-element.js'; | ||
|
|
||
| defineElement('${iconElementName}', Icon${ComponentName}); | ||
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| '${iconElementName}': Icon${ComponentName}; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <notice/notice> reported by reviewdog 🐶
Missing notice header
https://github.com/adobe/spectrum-web-components/blob/a5f2232defbe5423d5e0ee59c98b6eabcfed85cc/.eslintrc.json#L1-L195