-
Notifications
You must be signed in to change notification settings - Fork 208
[ENH] Add load_model functionality for regression ensemble models #2673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add load_model functionality for regression ensemble models #2673
Conversation
- Implement load_model for InceptionTimeRegressor and LITETimeRegressor - Add comprehensive test suite for load_model functionality - Fix is_fitted flag setting for loaded models
Thank you for contributing to
|
Please use the template. |
Hey @MatthewMiddlehurst , the issue this person's working on is #2641, which was opened by me. I have also mentioned in the issue itself that I'd love to work on it. I didn't work on it because I was waiting for approval of the maintainers and also to get #2631 reviewed so I understand if any other changes have to be made. |
I have updated the PR description to follow the template. Let me know if any further adjustments are needed. |
The code quality tests are failing currently. @inclinedadarsh unfortunate but i'm not going to stop people from creating PRs for unassigned open issues |
Oh okay. |
thanks for this, will review it soon ! |
Please fix the failing test. |
Please fix the failing test. HI @MatthewMiddlehurst , please find the Pull Request (PR) below , all the test case are passed except 2 skipped: Let me know if any further adjustments are needed. |
Please do not create multiple PRs, just update the current one by committing unless the changes required are substantial. Can you select one and reference the other in the comments please (you already have here so dont need to if you close the other). |
Hi @MatthewMiddlehurst , apologise for not closing this PR, as referred in this thread please find the Pull Request (PR) below , all the test case are passed except 2 skipped: Looking forward your comment in PR no : 2726. |
Reference Issues/PRs
Addresses #2673
What does this implement/fix? Explain your changes.
load_model
functionality forInceptionTimeRegressor
andLITETimeRegressor
to enable loading pre-trained regression ensemble models.load_model
functionality, including prediction consistency and error handling.is_fitted
flag for loaded models to ensure proper state tracking.PR Checklist
For all contributions
For new estimators and functions
load_model
docstrings to the API documentation.Does your contribution introduce a new dependency?
No new dependencies are introduced.