Skip to content

[ENH] Add load_model functionality for regression ensemble models #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

khansalman12
Copy link

@khansalman12 khansalman12 commented Mar 22, 2025

Reference Issues/PRs

Addresses #2673


What does this implement/fix? Explain your changes.

  • Implementation: Adds load_model functionality for InceptionTimeRegressor and LITETimeRegressor to enable loading pre-trained regression ensemble models.
  • Testing: Introduces a comprehensive test suite to validate the load_model functionality, including prediction consistency and error handling.
  • Fix: Corrects the is_fitted flag for loaded models to ensure proper state tracking.

PR Checklist

For all contributions

  • I've added myself to the list of contributors.
  • The PR title starts with [ENH] (enhancement).

For new estimators and functions

  • Added load_model docstrings to the API documentation.
  • (Optional) Added myself as a maintainer to relevant files.

Does your contribution introduce a new dependency?

No new dependencies are introduced.


- Implement load_model for InceptionTimeRegressor and LITETimeRegressor
- Add comprehensive test suite for load_model functionality
- Fix is_fitted flag setting for loaded models
@aeon-actions-bot aeon-actions-bot bot added the regression Regression package label Mar 22, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#7E0206}{\textsf{regression}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst
Copy link
Member

Please use the template.

@inclinedadarsh
Copy link
Contributor

inclinedadarsh commented Mar 23, 2025

Hey @MatthewMiddlehurst , the issue this person's working on is #2641, which was opened by me.

I have also mentioned in the issue itself that I'd love to work on it.

I didn't work on it because I was waiting for approval of the maintainers and also to get #2631 reviewed so I understand if any other changes have to be made.

@khansalman12 khansalman12 changed the title Add load_model functionality for regression ensemble models [ENH] Add load_model functionality for regression ensemble models Mar 23, 2025
@khansalman12
Copy link
Author

Hi @MatthewMiddlehurst,

I have updated the PR description to follow the template. Let me know if any further adjustments are needed.

@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label Mar 27, 2025
@MatthewMiddlehurst
Copy link
Member

The code quality tests are failing currently.

@inclinedadarsh unfortunate but i'm not going to stop people from creating PRs for unassigned open issues

@inclinedadarsh
Copy link
Contributor

Oh okay.
Didn't know this, but sorry for the bother.

@hadifawaz1999
Copy link
Member

thanks for this, will review it soon !

@MatthewMiddlehurst
Copy link
Member

Please fix the failing test.

@khansalman12
Copy link
Author

Please fix the failing test.

Please fix the failing test.

HI @MatthewMiddlehurst ,

please find the Pull Request (PR) below , all the test case are passed except 2 skipped:

Let me know if any further adjustments are needed.

@MatthewMiddlehurst
Copy link
Member

Please do not create multiple PRs, just update the current one by committing unless the changes required are substantial. Can you select one and reference the other in the comments please (you already have here so dont need to if you close the other).

@khansalman12
Copy link
Author

Please do not create multiple PRs, just update the current one by committing unless the changes required are substantial. Can you select one and reference the other in the comments please (you already have here so dont need to if you close the other).

Hi @MatthewMiddlehurst , apologise for not closing this PR, as referred in this thread

please find the Pull Request (PR) below , all the test case are passed except 2 skipped:

#2726

Looking forward your comment in PR no : 2726.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement regression Regression package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants