Skip to content

[ENH] Implement model loading functionality for InceptionTimeRegressor #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

khansalman12
Copy link

@khansalman12 khansalman12 commented Apr 4, 2025

Reference Issues/PRs

Addresses #2673


What does this implement/fix? Explain your changes.

  • Implementation: Adds load_model functionality for InceptionTimeRegressor and LITETimeRegressor to enable loading pre-trained regression ensemble models.
  • Testing: Introduces a comprehensive test suite to validate the load_model functionality, including prediction consistency and error handling.
  • Fix: Corrects the is_fitted flag for loaded models to ensure proper state tracking.

PR Checklist

For all contributions

  • I've added myself to the list of contributors.
  • The PR title starts with [ENH] (enhancement).

For new estimators and functions

  • Added load_model docstrings to the API documentation.
  • (Optional) Added myself as a maintainer to relevant files.

Does your contribution introduce a new dependency?

No new dependencies are introduced.


@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#7E0206}{\textsf{regression}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@khansalman12 khansalman12 deleted the feature/model-loading-functionality branch April 4, 2025 10:08
@khansalman12 khansalman12 restored the feature/model-loading-functionality branch April 4, 2025 11:17
@khansalman12 khansalman12 reopened this Apr 4, 2025
@khansalman12 khansalman12 changed the title Implement model loading functionality for InceptionTimeRegressor ENC Implement model loading functionality for InceptionTimeRegressor Apr 4, 2025
@khansalman12 khansalman12 changed the title ENC Implement model loading functionality for InceptionTimeRegressor [ENH] Implement model loading functionality for InceptionTimeRegressor Apr 4, 2025
@khansalman12 khansalman12 reopened this Apr 4, 2025
@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement regression Regression package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants