Skip to content

Update data.yml #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update data.yml #1412

wants to merge 2 commits into from

Conversation

SakuraFutaba
Copy link

functions related to ProcessPacket

@SakuraFutaba
Copy link
Author

SakuraFutaba commented Apr 29, 2025

Additionally, I found that the function ProcessPacketNpcYell calls g_Client::Game::UI::GoldSaucerYell_Instance.

__int64 __fastcall ProcessPacketNpcYell(__int64 *packet)
{
  int message; // r8d
  int u8; // r9d
  __int64 sourceID; // rdx
  __int128 u10; // [rsp+30h] [rbp-28h] BYREF

  message = *((unsigned __int16 *)packet + 6);  // 0xC
  u8 = *((_DWORD *)packet + 2);                 // 0x8
  sourceID = *packet;                           // 0x0
  u10 = *((_OWORD *)packet + 1);                // 0x10
  return sub_1409D4DA0((unsigned int)&g_Client::Game::UI::GoldSaucerYell_Instance, sourceID, message, u8, (__int64)&u10);
}

Maybe GoldSaucerYell.cs should be renamed to NpcYell.

Copy link
Contributor

@Haselnussbomber Haselnussbomber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a look at those 2 addresses again?

0x140A39D10: ProcessPacketEquipDisplayFlags
0x140A39DE0: ProcessPacketCompletedAchievements
0x140A39E30: ProcessPacketLandSetInitialize
0x140A3B4D0: ProcessPacketDailyQuests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This address resolves to something GcArmyExpedition (Squadron) related.
Couldn't find anything matching its name up to 10 versions back.

0x140A39B90: ProcessPacketRSVData
0x140A39BB0: ProcessPacketRSFData
0x140A39C10: ProcessPacketHuntingLogEntry
0x140A39C50: ProcessPacketNPCYell
0x140A39D10: ProcessPacketEquipDisplayFlags
0x140A39DE0: ProcessPacketCompletedAchievements
0x140A39E30: ProcessPacketLandSetInitialize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This address resolves to something Achievement related.
It seems to be matching an address in 7.2hf1. Here the correct address for 7.21:

Suggested change
0x140A39E30: ProcessPacketLandSetInitialize
0x140A3A510: ProcessPacketLandSetInitialize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants