Update data.yml

[SakuraFutaba]

functions related to ProcessPacket

[SakuraFutaba]

Additionally, I found that the function ProcessPacketNpcYell calls g_Client::Game::UI::GoldSaucerYell_Instance.

__int64 __fastcall ProcessPacketNpcYell(__int64 *packet)
{
  int message; // r8d
  int u8; // r9d
  __int64 sourceID; // rdx
  __int128 u10; // [rsp+30h] [rbp-28h] BYREF

  message = *((unsigned __int16 *)packet + 6);  // 0xC
  u8 = *((_DWORD *)packet + 2);                 // 0x8
  sourceID = *packet;                           // 0x0
  u10 = *((_OWORD *)packet + 1);                // 0x10
  return sub_1409D4DA0((unsigned int)&g_Client::Game::UI::GoldSaucerYell_Instance, sourceID, message, u8, (__int64)&u10);
}

Maybe GoldSaucerYell.cs should be renamed to NpcYell.

[Haselnussbomber]

Can you have a look at those 2 addresses again?

[Haselnussbomber]

This address resolves to something GcArmyExpedition (Squadron) related.
Couldn't find anything matching its name up to 10 versions back.

[SakuraFutaba]

0x140A3B4D0: ProcessPacketGcArmyExpeditionMissionResult
I have renamed the function. It is triggered by interacting with the Squadron Sergeant after completing a Squadron mission.

[Haselnussbomber]

This address resolves to something Achievement related.
It seems to be matching an address in 7.2hf1. Here the correct address for 7.21:

Suggested change

	0x140A39E30: ProcessPacketLandSetInitialize
	0x140A3A510: ProcessPacketLandSetInitialize

[Haselnussbomber]

I have some more comments after looking at those functions, but I'd like to make clear, that:
1) I'm not a maintainer - just someone who contributes a lot and looks at things.
2) I didn't test any of these addresses, so I can only guess as to what they do based on static analysis.

[Haselnussbomber]

This updates the GcArmyData.Members and the agents/addons GcArmyMemberList, and GcArmyMenberProfile (that's SE's typo, not ours).

[Haselnussbomber]

This seems to update progress, stats and available expeditions in GcArmyData.

[Haselnussbomber]

This has nothing to do with Expeditions or DailyQuests. It has something to do with ENpcs, but I don't know in what way.

[Haselnussbomber]

This updates InventoryManager.RetainerMarketPrices.

[Haselnussbomber]

The "MSQTracker" is called ScenarioTree. At the very end, it also seems to save some value from the ScenarioTree sheet (column Unknown0) into an MsqProgress config option (under certain conditions). I didn't even know that's a thing. 🤔

[SakuraFutaba]

Thank you for your review!
By the way, I noticed that some of these functions eventually call
Component::Exd::ExdModule_GetRowBySheetIndexAndRowId(*(_QWORD *)(g_Client::System::Framework::Framework_InstancePointer2 + 11072), 612i64, a1);
Is there a way to find out what the sheet name is for a given SheetIndex? (In this case 612)

[Haselnussbomber]

Yes, sheet indexes are in a the sqpack 0a0000 inside the exd/root.exl file (basically a csv file).
612 is ScenarioTree

You can extract it with https://github.com/NotNite/Alpha/ for example.

[SakuraFutaba]

Thanks a lot! I can now successfully read the exd/root.exl file with FFXIV Explorer.