Skip to content

Update data.yml #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update data.yml #1412

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12d52a8
Update data.yml
SakuraFutaba Apr 29, 2025
740f4ae
Update data.yml
SakuraFutaba Apr 29, 2025
3427b43
Fix and Update data.yml
SakuraFutaba May 2, 2025
2baca0a
Update data.yml
SakuraFutaba May 2, 2025
50ac94e
Merge remote-tracking branch 'origin/main' into futaba-main
SakuraFutaba May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ida/data.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,8 +335,16 @@ functions:
0x1400BA490: IsPartyMemberByNameOrContentId # (name, contentId)
0x1400BA5C0: GetPartyMemberClassJobByContentId
0x140844B40: ObjectIdToEntityId # returns invalid id if objectid is not a player
0x140A210E0: SendEventCompletePacket
0x140A21C20: ProcessPacketEventStart
0x140A21C80: ProcessPacketEventFinish
0x140A21D40: ProcessPacketBattleTalk
0x140A21DE0: ProcessPacketBalloonTalk
0x140A21A00: ProcessPacketEventPlay
0x140A21EE0: ProcessPacketSystemLogMessage
0x140A21FA0: ProcessPacketMapUpdate
0x140A22060: ProcessPacketFateInfo
0x140A220B0: ProcessPacketFateProgress
0x140A251B0: SendClientSelectDataConfigFlagsUpdate
0x140A25AE0: ProcessPacketSpawnPlayer
0x140A25BE0: ProcessPacketSpawnNPC
Expand Down Expand Up @@ -396,10 +404,25 @@ functions:
0x140A396B0: ProcessPacketUpdatePartyPositions
0x140A396E0: ProcessPacketUpdateAllianceNormalPositions
0x140A39710: ProcessPacketUpdateAllianceSmallPositions
0x140A39830: ProcessPacketChatIncoming
0x140A399E0: ProcessPacketInventoryTransaction
0x140A39A00: ProcessPacketItemInfo
0x140A39B90: ProcessPacketRSVData
0x140A39BB0: ProcessPacketRSFData
0x140A39C10: ProcessPacketHuntingLogEntry
0x140A39C50: ProcessPacketNPCYell
0x140A39D10: ProcessPacketEquipDisplayFlags
0x140A39DE0: ProcessPacketCompletedAchievements
0x140A39E30: ProcessPacketLandSetInitialize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This address resolves to something Achievement related.
It seems to be matching an address in 7.2hf1. Here the correct address for 7.21:

Suggested change
0x140A39E30: ProcessPacketLandSetInitialize
0x140A3A510: ProcessPacketLandSetInitialize

0x140A3B4D0: ProcessPacketDailyQuests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This address resolves to something GcArmyExpedition (Squadron) related.
Couldn't find anything matching its name up to 10 versions back.

Copy link
Author

@SakuraFutaba SakuraFutaba May 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x140A3B4D0: ProcessPacketGcArmyExpeditionMissionResult
I have renamed the function. It is triggered by interacting with the Squadron Sergeant after completing a Squadron mission.

0x140A3B610: ProcessPacketLandSetMap
0x140A3B710: ProcessPacketDailyQuestRepeatFlags
0x140A3B9A0: ProcessPacketPlayMotionSync
0x140A3BDF0: ProcessPacketMount
0x140A3C5A0: ProcessPacketPrepareZoning
0x140A3C600: ProcessPacketFall
0x140A3C660: ProcessPacketMSQTrackerComplete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "MSQTracker" is called ScenarioTree. At the very end, it also seems to save some value from the ScenarioTree sheet (column Unknown0) into an MsqProgress config option (under certain conditions). I didn't even know that's a thing. 🤔

0x140A3C6C0: ProcessPacketPerformance
0x140A3CAB0: ProcessPacketMapEffect
0x1416975F0: ProcessPacketUIModulePacket
0x1418BB270: ProcessPacketCountdown
Expand Down