Conversation
JacquesCarette
left a comment
There was a problem hiding this comment.
This is generally very nice. Just a few minor comments.
There might be a second round, as some thing might become more obvious once these clean-ups are down.
|
Thank you for your feedback. I removed all implicit arguments and everything still works. I'm very impressed by Agda's ability to fill in those arguments! I also implemented the other changes you proposed. Everything is so much cleaner now.. :O |
|
Don't go overboard on shortening. Sometimes some intermediate definitions are useful for conceptual clarity. But in general, yes, shorter is better. |
Increases clarity because: - the intermediate equations are only relevant in the context of the definition that uses them. - the type declaration of intermediate equations is much shorter.
|
I removed some definitions that seemed redundant and moved intermediate equations to the definitions that use them. This increases clarity because the typing judgements are much shorter. |
I proved the pasting law for pullbacks and added it to Pullback/Properties.agda.
I'm new to agda, so any feedback is much appreciated. I hope this fits into this library!