Skip to content

Pullback properties#449

Merged
JacquesCarette merged 5 commits intoagda:masterfrom
frederikgebert:pullback-properties
Feb 20, 2025
Merged

Pullback properties#449
JacquesCarette merged 5 commits intoagda:masterfrom
frederikgebert:pullback-properties

Conversation

@frederikgebert
Copy link

I proved the pasting law for pullbacks and added it to Pullback/Properties.agda.
I'm new to agda, so any feedback is much appreciated. I hope this fits into this library!

Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generally very nice. Just a few minor comments.

There might be a second round, as some thing might become more obvious once these clean-ups are down.

@frederikgebert
Copy link
Author

Thank you for your feedback. I removed all implicit arguments and everything still works. I'm very impressed by Agda's ability to fill in those arguments! I also implemented the other changes you proposed. Everything is so much cleaner now.. :O
I will go through the proof again in the next days to see if I can shorten it by removing unnecessary definitions.

@JacquesCarette
Copy link
Collaborator

Don't go overboard on shortening. Sometimes some intermediate definitions are useful for conceptual clarity. But in general, yes, shorter is better.

Increases clarity because:
- the intermediate equations are only relevant in the context of the definition that uses them.
- the type declaration of intermediate equations is much shorter.
@frederikgebert
Copy link
Author

I removed some definitions that seemed redundant and moved intermediate equations to the definitions that use them. This increases clarity because the typing judgements are much shorter.
I also removed some lines by using pull, push and extend reasoning.
Sorry for basically rewriting the whole proof but I think it makes more sense now.

@JacquesCarette JacquesCarette merged commit 8509bc5 into agda:master Feb 20, 2025
1 check passed
@frederikgebert frederikgebert deleted the pullback-properties branch February 21, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants