Resolve naming inconsistency between Iso and Category.isIso#1274
Merged
maxsnew merged 4 commits intoagda:masterfrom Dec 17, 2025
Merged
Resolve naming inconsistency between Iso and Category.isIso#1274maxsnew merged 4 commits intoagda:masterfrom
maxsnew merged 4 commits intoagda:masterfrom
Conversation
Contributor
Author
|
The first commit is nothing but the application of a straightforward search-and-replace and does not typecheck. The second commit manually resolves the handful of scope errors introduced and gets everything compiling again. I'm currently combing through the diff to undo any false-positives and will follow up with one last commit }:). By that point, this should be mergable, assuming this is even a welcome change. |
msyds
changed the title
Contributor
Author
|
(A few of said false-positives ( |
Collaborator
|
I have no strong opinions on this, so if @maxsnew thinks it's better I'm fine with merging |
LorenzoMolena
added a commit
to LorenzoMolena/cubical
that referenced
this pull request
Jan 24, 2026
* Resolve naming inconsistency between Iso and Category.isIso (agda#1274) s/leftInv/ret; s/rightInv/sec --------- Co-authored-by: Madeleine Sydney Ślaga <msyds@deertopia.net> * isIso name change fix (agda#1281) * Update fin (agda#1279) * Exchange Fin in Cubical.Data.Fin for the deifinition from Cubical.Data.Fin.Inductive. WIP * Fixed finj, predFin, inject<, flast, ¬Fin0 to work with new definition of Fin. * Minor changes * Fix sumFinGen * fix any? * Everything type checks now. Important changes: - Implicit argument added to toN - Implicit arguments in toN-injective slightly changed - Argument changed from implicit to explicit in elim * some formatting * change ¬Fin0 * remove comments * Add <ᵗ-asym * make properties type check * Remove dependencies on Cubical.Data.Fin.Inductive.Base * Things that work * Properties type check * more working files * factorEquiv * comment fix * LehmerCode type checks * SumFin.Base type checks * some cleanup and Axiom.Choice type checks not reliant on old Fin * Remove dependence on Fin.Inductive * Remove dependence on Fin.Inductive * Remove dependency on Fin.Infuctive * Remove dependency on Fin.Inductive * Remove dependencies on Fin.Inductive * type check * fix FinSet * _<ᵗ_ is well founded * type checks with new Fin * Everything builds * Move everything from Fin.Inductive.Properties to Fin.Properties and remove Fin.Inductive, Fin.Inductive.Base, Fin.Inductive.Properties * some cleanup * more cleanup * fix trailing whitespaces * files end with newline --------- Co-authored-by: croos <76143n@gmail.com> * fix defintions of `min` and `max`, add comment on limitations of `UsingEq` (agda#1270) * Change implementation of Inductive Order on Nat (agda#1283) * use boolean comparison in `Nat.Order.Inductive`, add non-strict and flipped inductive order, make faster instance search in `Fin.Literals` * fix typo * Place holder for paper (agda#1286) * placeholder * whitespae * Cellpaper2 (agda#1287) * placeholder * whitespae * form * fix imports: `Fin.Inductive.Base/Properties` → `Fin.Base/Properties` --------- Co-authored-by: Madeleine Sydney Ślaga <65362461+msyds@users.noreply.github.com> Co-authored-by: Madeleine Sydney Ślaga <msyds@deertopia.net> Co-authored-by: Max S. New <maxsnew@gmail.com> Co-authored-by: Caroline Roos <croos.math@gmail.com> Co-authored-by: croos <76143n@gmail.com> Co-authored-by: Axel Ljungström <49276137+aljungstrom@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1251.
This is a very big rename. It would've been much easier to rename
isIso's fields to matchIso's rather than the other way around, but I strongly believe that would leave us with an even worse inconsistency.