Resolve naming inconsistency between Iso and Category.isIso #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The first commit is nothing but the application of a straightforward search-and-replace and does not typecheck. The second commit manually resolves the handful of scope errors introduced and gets everything compiling again. I'm currently combing through the diff to undo any false-positives and will follow up with one last commit }:). By that point, this should be mergable, assuming this is even a welcome change. |
msyds
changed the title
Author
|
(A few of said false-positives ( |
Contributor
|
I have no strong opinions on this, so if @maxsnew thinks it's better I'm fine with merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1251.
This is a very big rename. It would've been much easier to rename
isIso's fields to matchIso's rather than the other way around, but I strongly believe that would leave us with an even worse inconsistency.