docs(interp): fcmp header describes duck_fcmp order, not stale IEEE claim - #31
Merged
Merged
Conversation
… IEEE claim The Inst::Cmp F64 arm has used exec::duck_fcmp (NaN = NaN, NaN above everything, -0.0 = 0.0) since the DuckDB pin; the module header still claimed IEEE-ordered NaN-is-false semantics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ahrzb
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module header in
src/specializer/exec/interp.rsstill saidfcmpis IEEE-ordered (every NaN predicate false exceptne). The implementation (Inst::Cmp,Ty::F64arm) has usedexec::duck_fcmp— DuckDB DOUBLE order where NaN = NaN, NaN sorts above everything, and-0.0 = 0.0— as pinned bypin_fcmp_nan_ordering/pin_fcmp_nan_eq_nan_and_zero_order.Doc-only change; updates the one bullet to reference
exec::duck_fcmpso spec text stops copying the stale IEEE claim.Verified:
cargo test specializer— 127 passed, 0 failed.🤖 Generated with Claude Code