Skip to content

docs(interp): fcmp header describes duck_fcmp order, not stale IEEE claim #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahrzb merged 1 commit into from
Jul 26, 2026
Merged

docs(interp): fcmp header describes duck_fcmp order, not stale IEEE claim #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/specializer/exec/interp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@
//! * `iadd`/`isub`/`imul` trap on i64 overflow (SQL overflow is an error,
//! not a wrap); `idiv`/`irem` trap on zero and on `i64::MIN / -1`.
//! * `f*` arithmetic is raw IEEE — inf/nan flow through, no traps.
//! * `fcmp` is IEEE-ordered: every predicate involving NaN is false, except
//! `ne`, which is `!(a == b)` and therefore true. SQL NULL/NaN policy is
//! the lowering's job, expressed with flags around these primitives.
//! * `fcmp` uses DuckDB's DOUBLE order (`exec::duck_fcmp`): IEEE except that
//! NaN equals NaN and sorts above everything, and `-0.0 = 0.0`. SQL
//! NULL/NaN policy is the lowering's job, expressed with flags around
//! these primitives.
//! * `icmp` is i64 order; `scmp` is byte order (Rust `str` cmp).
//! * `itof` is `as f64` (may round — same as DuckDB's BIGINT->DOUBLE).
//! * `ftoi.trunc` rounds toward zero; `ftoi.round` half-away-from-zero
Expand Down