Port wandb_dir_in_experiment_dir option to public code
#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerkclark
changed the title
wandb_in_experiment_dir option to public codewandb_dir_in_experiment_dir option to public code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows toggling whether the
wandbdirectory will be stored in theexperiment_diror in/tmp. By default it retains the existing behavior, where it is stored in local/tmp. Storing it in theexperiment_diris useful when running bare-metal, since it ensures that the directory is unique and can be accessed from nodes that have internet connectivity.Changes:
wandb_dir_in_experiment_diroption (defaultFalse) to theLoggingConfigto toggle whether thewandbdirectory will be stored in the experiment directory or not.