Skip to content

Port wandb_dir_in_experiment_dir option to public code #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

Port wandb_dir_in_experiment_dir option to public code #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions fme/core/logging_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ class LoggingConfig:
log_to_wandb: Whether to log to Weights & Biases.
log_format: Format of the log messages.
level: Sets the logging level.
wandb_dir_in_experiment_dir: Whether to create the wandb_dir in the
experiment_dir or in local /tmp (default False).
"""

project: str = "ace"
Expand All @@ -45,6 +47,7 @@ class LoggingConfig:
log_to_wandb: bool = True
log_format: str = "%(asctime)s - %(name)s - %(levelname)s - %(message)s"
level: str | int = logging.INFO
wandb_dir_in_experiment_dir: bool = False

def __post_init__(self):
self._dist = Distributed.get_instance()
Expand Down Expand Up @@ -76,7 +79,6 @@ def configure_wandb(
self,
config: Mapping[str, Any],
env_vars: Mapping[str, Any] | None = None,
wandb_dir: str | None = DEFAULT_TMP_DIR,
resumable: bool = True,
resume: Any = None,
**kwargs,
Expand All @@ -94,14 +96,21 @@ def configure_wandb(
)
elif env_vars is not None:
config_copy["environment"] = env_vars

experiment_dir = config["experiment_dir"]
if self.wandb_dir_in_experiment_dir:
wandb_dir = experiment_dir
else:
wandb_dir = DEFAULT_TMP_DIR

# must ensure wandb.configure is called before wandb.init
wandb = WandB.get_instance()
wandb.configure(log_to_wandb=self.log_to_wandb)
wandb.init(
config=config_copy,
project=self.project,
entity=self.entity,
experiment_dir=config["experiment_dir"],
experiment_dir=experiment_dir,
resumable=resumable,
dir=wandb_dir,
**kwargs,
Expand Down