Allow caching of middleware construction #10890
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Dreamsorcerer
commented
May 19, 2025
aiohttp/client_reqrep.py
Outdated
Comment on lines
246
to
250
| response_params: _ResponseParams, | ||
| timeout: ClientTimeout, | ||
| params: Query = None, | ||
| headers: Optional[LooseHeaders] = None, | ||
| skip_auto_headers: Optional[Iterable[str]] = None, |
There was a problem hiding this comment.
I'm just thinking through future maintainability of this class. Should we put in a **kwargs: Any and not use it, so that any subclass is required to include that and pass it through the super() call? That way we should be pretty safe to add parameters in future without worrying about breaking any subclasses.
|
@bdraco Does the proxy code have any impact on middlewares? Seems to be a ClientRequest created here with a lot less arguments, just wondering if there's any issue here: Line 1364 in 180b5ab Otherwise, I guess that's why all those parameters have defaults currently, in which case we'll need to do the same for these 2 as well. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
❌ 11 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Feels to me like there should be a separate ClientProxyRequest or something. I think if we separated them, it'd remove a bunch of asserts and make static typing a lot cleaner. |
CodSpeed Performance ReportMerging #10890 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just putting this here so we don't forget about it. Feel free to pick it up.