Slightly rewrite internal C API to reflect the modern dict API#1187
Merged
asvetlov merged 2 commits intoaio-libs:masterfrom Jun 22, 2025
Merged
Slightly rewrite internal C API to reflect the modern dict API#1187asvetlov merged 2 commits intoaio-libs:masterfrom
asvetlov merged 2 commits intoaio-libs:masterfrom
Conversation
Member
Author
CodSpeed Performance ReportMerging #1187 will degrade performances by 14.46%Comparing Summary
Benchmarks breakdown
|
Member
Vizonex
added a commit
to Vizonex/multidict
that referenced
this pull request
Jun 22, 2025
3 tasks
asvetlov
added a commit
that referenced
this pull request
Jun 24, 2025
It is a follow-up PR for #1187 that corrects retval of internal `md_get_all()` function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
md_get_one(),md_get_all(),md_pop_one(),md_pop_all()now return1if key exists in multidict,0otherwise.md_set_default()now also returns1if key exists in multidict,0if key doesn't exist and the default was iserted into the object.-1in case of error.The PR doesn't affect any public API; it is a preparation step for introducing multidict's public C API.