Skip to content

chore: update pyproject.toml python requirement #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 22, 2025

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Feb 1, 2025

Summary by CodeRabbit

  • Compatibility

    • Extended Python version support to include Python 3.13
    • Updated project's Python version constraints in project configuration
    • Excluded Python 3.12 from the testing matrix due to compatibility issues
  • Tests

    • Added a condition to skip specific tests if using Python 3.12 or higher due to known issues

@aaronsteers
Copy link
Contributor Author

aaronsteers commented Feb 1, 2025

/poetry-lock

poetry lock job started... Check job output.

poetry lock applied successfully.

@aaronsteers aaronsteers changed the title Update pyproject.toml python requirement chore: update pyproject.toml python requirement Feb 1, 2025
Copy link
Contributor

coderabbitai bot commented Feb 1, 2025

📝 Walkthrough

Walkthrough

The pull request modifies the pyproject.toml file to expand Python version compatibility. The Python version constraint has been updated from supporting versions >=3.10,<3.12 to >=3.10,<3.13, allowing the project to support Python 3.13. Additionally, the testing workflow has been adjusted to comment out Python 3.12 from the testing matrix, and a new decorator has been added to skip tests for Python 3.12 due to compatibility issues.

Changes

File Change Summary
pyproject.toml Updated Python version constraint from >=3.10,<3.12 to >=3.10,<3.13
.github/workflows/python_pytest.yml Commented out Python version 3.12 in the pytest job matrix due to certain tests not working on that version
tests/unit_tests/test_lowcode_connectors.py Added @pytest.mark.skipif decorator to test_nocode_execution to skip tests for Python 3.12 or higher

Possibly related PRs

  • Chore(deps): Update psycopg to ^3.1.19 for macOS <14 compatibility #538: The changes in the main PR focus on updating the Python version constraint in pyproject.toml, while the retrieved PR modifies the version of the psycopg dependency in the same file, indicating that they are related through their modifications to pyproject.toml.
  • chore: add python 3.12 support #596: The changes in the main PR, which involve updating the Python version constraint in pyproject.toml, are related to the modifications in the retrieved PR that add Python 3.12 support in the testing workflow, as both address compatibility with Python 3.12.
  • Chore(deps): Bump CDK, nltk, and python-ulid to latest #537: The changes in the main PR and the retrieved PR both involve updates to the Python version constraints in the pyproject.toml file, specifically expanding the upper limit to <3.13, indicating a direct relationship at the code level.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4d49fc and 0416ade.

📒 Files selected for processing (2)
  • .github/workflows/python_pytest.yml (1 hunks)
  • tests/unit_tests/test_lowcode_connectors.py (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Pytest (All, Python 3.11, Windows)
  • GitHub Check: Pytest (No Creds)
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.10, Windows)
  • GitHub Check: Pytest (Fast)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
🔇 Additional comments (3)
.github/workflows/python_pytest.yml (1)

136-136: LGTM on commenting out Python 3.12 from the test matrix.

The comment provides good context about why Python 3.12 is excluded from testing. This aligns well with the update to support Python 3.13 in pyproject.toml. Might be worth considering adding a tracking issue to eventually fix the tests for 3.12, wdyt?

tests/unit_tests/test_lowcode_connectors.py (2)

5-5: Looks good!

Clean addition of the sys import needed for the version check.


21-24: Good addition of the skipif decorator.

This is a nice complementary change to the workflow update. The specific reason provided helps other developers understand exactly why the test is skipped in Python 3.12+.

Since this is skipping for any Python version >= 3.12, would it make sense to make the condition more specific to just 3.12 if you're planning to support 3.13, or is the pokeAPI issue expected to persist in 3.13 as well? wdyt?

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aaronsteers
Copy link
Contributor Author

@coderabbitai review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pyproject.toml (1)

16-16: Confirm Python Version Constraint Update
The Python version requirement has been updated to support up to Python 3.13. Would you like to double-check that all dependencies—especially those with their own Python constraints (e.g., sqlalchemy-bigquery using python = "<3.13")—remain consistent and won’t lead to conflicts in future releases? wdyt?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc2c533 and b4d49fc.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Pytest (All, Python 3.12, Windows)
  • GitHub Check: Pytest (All, Python 3.12, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.11, Windows)
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.10, Windows)
  • GitHub Check: Pytest (No Creds)
  • GitHub Check: Pytest (All, Python 3.10, Ubuntu)
  • GitHub Check: Pytest (Fast)

@aaronsteers aaronsteers enabled auto-merge (squash) February 1, 2025 02:36
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Aaron <AJ> Steers <[email protected]>
@aaronsteers aaronsteers merged commit 9de468a into main Mar 22, 2025
19 checks passed
@aaronsteers aaronsteers deleted the aj/update-python-requirement branch March 22, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant