refactor: remove internal/local/local #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesnodgrass
approved these changes
Jun 27, 2025
Base automatically changed from
bernielomax/refactor/restructure-packages
to
main
June 27, 2025 23:22
bernielomax
force-pushed
the
bernielomax/refactor/remove-local-local
branch
from
14644ba to
f37dc83
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final changes that follow #165. The end result is that
internal/local/localbecomesinternal/service. It is this package that is responsible for managing the Abctl service and its components. This probably isn't the final structure. But provides enough logical separation between the packages and their responsibilities for now.