Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,23 +1,25 @@
package local
package airbyte

import (
"bufio"
"encoding/json"
"io"
)

type logScanner struct {
// LogScanner
type LogScanner struct {
scanner *bufio.Scanner
line logLine
Line logLine
}

func newLogScanner(r io.Reader) *logScanner {
return &logScanner{
// NewLogScanner returns an initialized Airbyte log scanner.
func NewLogScanner(r io.Reader) *LogScanner {
return &LogScanner{
scanner: bufio.NewScanner(r),
}
}

func (j *logScanner) Scan() bool {
func (j *LogScanner) Scan() bool {
for {
if ok := j.scanner.Scan(); !ok {
return false
Expand All @@ -27,16 +29,16 @@ func (j *logScanner) Scan() bool {
err := json.Unmarshal(j.scanner.Bytes(), &data)
// not all lines are JSON. don't propogate errors, just include the full line.
if err != nil {
j.line = logLine{Message: j.scanner.Text()}
j.Line = logLine{Message: j.scanner.Text()}
} else {
j.line = data
j.Line = data
}

return true
}
}

func (j *logScanner) Err() error {
func (j *LogScanner) Err() error {
return j.scanner.Err()
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package local
package airbyte

import (
"strings"
Expand All @@ -11,16 +11,16 @@ nonjsonline
`)

func TestJavaLogScanner(t *testing.T) {
s := newLogScanner(strings.NewReader(testLogs))
s := NewLogScanner(strings.NewReader(testLogs))

expectLogLine := func(level, msg string) {
s.Scan()

if s.line.Level != level {
t.Errorf("expected level %q but got %q", level, s.line.Level)
if s.Line.Level != level {
t.Errorf("expected level %q but got %q", level, s.Line.Level)
}
if s.line.Message != msg {
t.Errorf("expected msg %q but got %q", msg, s.line.Message)
if s.Line.Message != msg {
t.Errorf("expected msg %q but got %q", msg, s.Line.Message)
}
if s.Err() != nil {
t.Errorf("unexpected error %v", s.Err())
Expand Down
35 changes: 0 additions & 35 deletions internal/cmd/local/command.go

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (
"fmt"

"github.com/airbytehq/abctl/internal/airbyte"
"github.com/airbytehq/abctl/internal/cmd/local/local"
"github.com/airbytehq/abctl/internal/k8s"
"github.com/airbytehq/abctl/internal/service"
"github.com/airbytehq/abctl/internal/telemetry"
"github.com/pterm/pterm"
"go.opencensus.io/trace"
Expand All @@ -33,7 +33,7 @@ func (cc *CredentialsCmd) Run(ctx context.Context, provider k8s.Provider, telCli
spinner := &pterm.DefaultSpinner

return telClient.Wrap(ctx, telemetry.Credentials, func() error {
k8sClient, err := local.DefaultK8s(provider.Kubeconfig, provider.Context)
k8sClient, err := service.DefaultK8s(provider.Kubeconfig, provider.Context)
if err != nil {
pterm.Error.Println("No existing cluster found")
return nil
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import (
"context"
"fmt"

"github.com/airbytehq/abctl/internal/cmd/local/local"
"github.com/airbytehq/abctl/internal/k8s"
"github.com/airbytehq/abctl/internal/service"
"github.com/airbytehq/abctl/internal/telemetry"
"github.com/pterm/pterm"
"go.opencensus.io/trace"
Expand All @@ -19,7 +19,7 @@ func (d *DeploymentsCmd) Run(ctx context.Context, telClient telemetry.Client, pr
ctx, span := trace.StartSpan(ctx, "local deployments")
defer span.End()

k8sClient, err := local.DefaultK8s(provider.Kubeconfig, provider.Context)
k8sClient, err := service.DefaultK8s(provider.Kubeconfig, provider.Context)
if err != nil {
return err
}
Expand Down
Loading