feat: add additional stats to AirbyteStateStats #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpgrailsdev
reviewed
Oct 8, 2025
| description: > | ||
| additional stats for this state message. The values are defined as a double to account for integer overflows, and the values should always have a decimal point for proper serialization | ||
| type: object | ||
| additionalProperties: |
There was a problem hiding this comment.
Curious as to why this is under additionalProperties instead of properties? Is that to make it optional? I thought that the properties are only required if we declare them as required, like in AirbyteGlobalState.
There was a problem hiding this comment.
This is the json schema way of saying all the additional properties of this object are of type number.
https://json-schema.org/understanding-json-schema/reference/object
There was a problem hiding this comment.
Is there how we are saying this object is an open map of string to number?
There was a problem hiding this comment.
Spoke offline: this is how we enforce the values in the object needs to be a number.
davinchia
approved these changes
Oct 9, 2025
gosusnp
deleted the
gosusnp/add-additional-stats-to-airbyte-state-stats
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AirbyteStateStatsenables sources and destination to report the number of records observed per state. This enabled validation of data consistency.This change adds an optional
AirbyteStateStats.additionalStatswhich is defined as an object of keys tonumber.The intent is to allow a looser contract to enable connectors to report additional stats related to the data being moved. For example, we introduced
AirbyteRecordMessageMetaChangewhich describes modifications connectors may need to perform on the data. The goal of this change would be to enable the connectors to report statistics related to those changes to enable better observability without having to scan the destination to extract this information.