Skip to content

feat: add additional stats to AirbyteStateStats #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

feat: add additional stats to AirbyteStateStats #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,12 @@ definitions:
the number of records which were rejected for this state message, for this stream or global. While the value should always be a
round number, it is defined as a double to account for integer overflows, and the value should always have a decimal point for proper serialization.
type: number
additionalStats:
description: >
additional stats for this state message. The values are defined as a double to account for integer overflows, and the values should always have a decimal point for proper serialization
type: object
additionalProperties:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious as to why this is under additionalProperties instead of properties? Is that to make it optional? I thought that the properties are only required if we declare them as required, like in AirbyteGlobalState.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the json schema way of saying all the additional properties of this object are of type number.
https://json-schema.org/understanding-json-schema/reference/object

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there how we are saying this object is an open map of string to number?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke offline: this is how we enforce the values in the object needs to be a number.

type: number
AirbyteLogMessage:
type: object
additionalProperties: true
Expand Down
Loading