Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

This PR targets the following PR:


What

This is a test PR to verify that the migration guide validation fix in #67594 correctly handles connectors with MDX imports before their migration guide title. This PR should NOT be merged.

These changes recreate the schema additions from PR #67077 for the source-zendesk-support connector, which has a migration guide that starts with an MDX import statement.

Related to GitHub issue #45667.

How

Manually recreated the three file changes from PR #67077:

  1. Added missing SLA fields (sla, group_sla, status, deleted) to the ticket_metric_events schema in the connector manifest
  2. Bumped connector version from 4.10.12 to 4.10.13
  3. Added corresponding changelog entry

Review guide

⚠️ This is a test PR - DO NOT MERGE ⚠️

  1. airbyte-integrations/connectors/source-zendesk-support/manifest.yaml - Verify the SLA schema definitions are correctly formatted (95+ lines of nested schema)
  2. airbyte-integrations/connectors/source-zendesk-support/metadata.yaml - Confirm version bump to 4.10.13
  3. docs/integrations/sources/zendesk-support.md - Check changelog entry accuracy and formatting
  4. CI checks - Verify that migration guide validation PASSES for source-zendesk-support (this is the main test objective)

User Impact

Testing only - No user impact intended since this PR will not be merged.

The original changes would add missing SLA fields to the ticket_metric_events stream, allowing users to access SLA policy information, target times, and status data that was previously unavailable.

Can this PR be safely reverted and rolled back?

  • YES 💚 - This is a test PR that should be closed without merging

Link to Devin run: https://app.devin.ai/sessions/d66e3af38e1d4d5396c475c9215e827f
Requested by: [email protected]

Copy link
Contributor Author

Original prompt from [email protected]
@Devin Take a look at the documentaton.py tests in airbyte: airbyte-ci/connectors/connectors_qa/src/connectors_qa/checks/documentation/documentation.py

There's a failing test here: <https://github.com/airbytehq/airbyte/actions/runs/18244805367/job/51951361039?pr=67077>

The reason the test is failing is because the migration guide begins with an MDX import.

I'd like to preserve the requirement to have a proper Migration Guide title. However, there are valid cases where Markdown metadata or imports will precede this, so this title should not necessarily be on the first line. Can you provide a suggestion for how this logic will be a bit more flexible?
Thread URL: https://airbytehq-team.slack.com/archives/D08FX8EC9L0/p1760036729536019?thread_ts=1760036729.536019

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Contributor

github-actions bot commented Oct 9, 2025

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version type=patch changelog='foo' - Bump the Bulk CDK's version. type can be major/minor/patch.
  • Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-2wzktfw7s-airbyte-growth.vercel.app

Built with commit 41151f0.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

github-actions bot commented Oct 9, 2025

source-zendesk-support Connector Test Results

54 tests   50 ✅  1m 1s ⏱️
 2 suites   4 💤
 2 files     0 ❌

Results for commit 41151f0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inactive

Development

Successfully merging this pull request may close these issues.

2 participants