-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix(source-zendesk-chat): Handle 404 errors for deleted records #67607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(source-zendesk-chat): Handle 404 errors for deleted records #67607
Conversation
Add response_filters to error handlers for chats and agent_timeline streams to gracefully ignore 404 errors when encountering deleted records. This prevents sync failures when the API returns 404 for records that have been deleted. Fixes airbytehq/oncall#9459 Co-Authored-By: unknown <>
Original prompt from API User
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
/bump-version type=patch |
…guide header Co-Authored-By: unknown <>
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit b03b17c. |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
What
Fixes sync failures in Zendesk Chat connector when encountering 404 errors for deleted records during incremental syncs. Resolves oncall issue #9459.
The connector was failing entire syncs when the Zendesk API returned 404 responses for records that had been deleted between sync runs, particularly affecting the
chats
andagent_timeline
incremental streams.How
Added response filters to the
DefaultErrorHandler
configuration for thechats
andagent_timeline
streams in the declarative manifest. The filters:IGNORE
to skip the missing records rather than fail the syncAlso includes necessary version bump (1.2.20 → 1.2.21) and documentation updates.
Review guide
airbyte-integrations/connectors/source-zendesk-chat/manifest.yaml
- Core fix adding 404 response filters to two stream definitions (lines 119-122, 254-257)airbyte-integrations/connectors/source-zendesk-chat/metadata.yaml
- Version incrementdocs/integrations/sources/zendesk-chat.md
- Changelog entry additiondocs/integrations/sources/zendesk-chat-migrations.md
- Header formatting fix (CI requirement)Key review points:
IGNORE
is the correct action for 404s on these streams (vs failing fast on data inconsistency)User Impact
Positive:
Potential risks:
Can this PR be safely reverted and rolled back?
Reverting would restore the previous error handling behavior where 404s cause sync failures.
Requested by: @agarctfi
Devin session: https://app.devin.ai/sessions/f70a175bc7ab4c1fa56735434bd3ad45