Skip to content

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Oct 13, 2025

Important

Auto-merge enabled.

This PR is set to merge automatically when all requirements are met.

Summary by CodeRabbit

  • New Features
    • Added a template for MCP configuration to streamline setup of a stdio-based MCP server.
  • Refactor
    • Simplified generated manifest scaffold by removing the dynamic schema loader option from the paginator section.
  • Tests
    • Updated unit test to no longer assert inclusion of the dynamic schema loader.
  • Chores
    • Ignored local MCP configuration files (.mcp.json) in version control.

Copy link

coderabbitai bot commented Oct 13, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Added a template MCP config and .gitignore rule for .mcp.json, and removed the DynamicSchemaLoader schema_loader block from the paginator in the manifest scaffold; corresponding test assertion for DynamicSchemaLoader was removed. No public APIs changed.

Changes

Cohort / File(s) Summary of Changes
MCP config & ignore rule
/.gitignore, /.mcp.json.template
Added an ignore rule for .mcp.json. Added .mcp.json.template defining a single stdio MCP server connector-builder-mcp that runs uv run airbyte-connector-builder-mcp with an empty environment.
Manifest scaffold pagination config
connector_builder_mcp/manifest_scaffold.py
Removed the schema_loader block referencing DynamicSchemaLoader from the paginator section generated in the manifest YAML.
Test update
tests/unit/test_manifest_scaffold.py
Removed the assertion that expected "DynamicSchemaLoader" in the test; other assertions remain (type, absence of ERROR:, presence of TODO).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the primary change in this PR, namely the removal of the DynamicSchemaLoader from the scaffold, and uses clear and specific language that aligns with the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7feec09 and 543af52.

📒 Files selected for processing (1)
  • tests/unit/test_manifest_scaffold.py (0 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added bug Something isn't working security labels Oct 13, 2025
Copy link

👋 Welcome to the Airbyte Connector Builder MCP!

Thank you for your contribution! Here are some helpful tips and reminders for your convenience.

Testing This Branch via MCP

To test the changes in this specific branch with an MCP client like Claude Desktop, use the following configuration:

{
  "mcpServers": {
    "connector-builder-mcp-dev": {
      "command": "uvx",
      "args": ["--from", "git+https://github.com/airbytehq/connector-builder-mcp.git@fix--remove-DynamicSchemaLoader-from-scaffold", "connector-builder-mcp"]
    }
  }
}

Testing This Branch via CLI

You can test this version of the MCP Server using the following CLI snippet:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/connector-builder-mcp.git@fix--remove-DynamicSchemaLoader-from-scaffold#egg=airbyte-connector-builder-mcp' --help

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /build-connector - Builds the default connector on-demand using the AI builder
  • /build-connector prompt="<your prompt>" - Builds a connector on-demand using the AI builder
  • /poe <command> - Runs any poe command in the uv virtual environment

AI Builder Evaluations

AI builder evaluations run automatically under the following conditions:

  • When a PR is marked as "ready for review"
  • When a PR is reopened

A set of standardized evaluations also run on a schedule (Mon/Wed/Fri at midnight UTC) and can be manually triggered via workflow dispatch.

Helpful Resources

If you have any questions, feel free to ask in the PR comments or join our Slack community.

📝 Edit this welcome message.

@aaronsteers aaronsteers enabled auto-merge (squash) October 13, 2025 16:39
Copy link

github-actions bot commented Oct 13, 2025

PyTest Results (Fast)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 543af52. ± Comparison against base commit e073c97.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 13, 2025

PyTest Results (Full)

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 543af52.

♻️ This comment has been updated with latest results.

@aaronsteers aaronsteers merged commit b6c0a46 into main Oct 13, 2025
13 of 14 checks passed
@aaronsteers aaronsteers deleted the fix--remove-DynamicSchemaLoader-from-scaffold branch October 13, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant