Skip to content

fix: remove DynamicSchemaLoader from scaffold #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2025
+14 −3
Merged

fix: remove DynamicSchemaLoader from scaffold #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41001c4
fix: remove DynamicSchemaLoader from scaffold
aaronsteers Oct 13, 2025
7feec09
ignore .mcp.json, add template
aaronsteers Oct 13, 2025
543af52
update test
aaronsteers Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,3 +217,4 @@ cython_debug/
marimo/_static/
marimo/_lsp/
__marimo__/
.mcp.json
13 changes: 13 additions & 0 deletions .mcp.json.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"mcpServers": {
"connector-builder-mcp": {
"type": "stdio",
"command": "uv",
"args": [
"run",
"airbyte-connector-builder-mcp"
],
"env": {}
}
}
}
2 changes: 0 additions & 2 deletions connector_builder_mcp/manifest_scaffold.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@ def _generate_manifest_yaml_directly(
# pagination_strategy:
# type: PageIncrement
# start_from_page: 1
schema_loader:
type: DynamicSchemaLoader # TODO: Consider switching to static schema for production performance
# TODO: Uncomment and configure incremental sync when known
# incremental_sync:
# type: DatetimeBasedCursor
Expand Down
1 change: 0 additions & 1 deletion tests/unit/test_manifest_scaffold.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ def test_dynamic_schema_loader_included() -> None:

assert isinstance(result, str)
assert not result.startswith("ERROR:")
assert "DynamicSchemaLoader" in result
assert "TODO" in result


Expand Down
Loading