Compiler warning -Werror=stringop-truncation fix for error.c#700
Open
sbytnar wants to merge 1 commit intoakheron:masterfrom
Open
Compiler warning -Werror=stringop-truncation fix for error.c#700sbytnar wants to merge 1 commit intoakheron:masterfrom
sbytnar wants to merge 1 commit intoakheron:masterfrom
Conversation
…und depends on the length of the source argument [-Werror=stringop-truncation]"
Author
|
This would fix #630 |
| length = strlen(source); | ||
| if (length < JSON_ERROR_SOURCE_LENGTH) | ||
| strncpy(error->source, source, length + 1); | ||
| strncpy(error->source, source, JSON_ERROR_SOURCE_LENGTH); |
There was a problem hiding this comment.
Passing JSON_ERROR_SOURCE_LENGTH here seems unnecessary as the length has just been checked. We already know the length of source and have checked it will fit in the output buffer, therefore I think this is better:
memcpy(error->source, source, length + 1);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. This warning is emitted by newer versions of gcc. The project I'm working with treats this particular warning as an error.
The fix below makes the compiler happy.
The full error message emitted looks like this:
Thank you.
--Steve