Skip to content

Compiler warning -Werror=stringop-truncation fix for error.c #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbytnar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compiler warning -Werror=stringop-truncation fix for error.c #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/error.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ void jsonp_error_set_source(json_error_t *error, const char *source) {

length = strlen(source);
if (length < JSON_ERROR_SOURCE_LENGTH)
strncpy(error->source, source, length + 1);
strncpy(error->source, source, JSON_ERROR_SOURCE_LENGTH);
Copy link

@rosslagerwall rosslagerwall Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing JSON_ERROR_SOURCE_LENGTH here seems unnecessary as the length has just been checked. We already know the length of source and have checked it will fit in the output buffer, therefore I think this is better:

         memcpy(error->source, source, length + 1);

else {
size_t extra = length - JSON_ERROR_SOURCE_LENGTH + 4;
memcpy(error->source, "...", 3);
Expand Down