Fix redundant "jenkins" in the url environment variable name#3
Open
dpitman-nvda wants to merge 3 commits intoakhilthomas236:mainfrom
Open
Fix redundant "jenkins" in the url environment variable name#3dpitman-nvda wants to merge 3 commits intoakhilthomas236:mainfrom
dpitman-nvda wants to merge 3 commits intoakhilthomas236:mainfrom
Conversation
Signed-off-by: Derek Pitman <dpitman@nvidia.com>
Signed-off-by: Derek Pitman <dpitman@nvidia.com>
Signed-off-by: Derek Pitman <dpitman@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Since the Pydantic model_config prefixes all input environment variables with
JENKINS_, naming the variablejenkins_urlis redundant and confusingly makes the environment variable nameJENKINS_JENKINS_URL. This PR fixes that duplicate naming.Changes Made
Renamed
jenkins_urltourlinconfig.py.How to Test
N/A
Checklist