feat: telemetry for shard handoff#32888
Merged
sebastian-alfers merged 1 commit intosharding-telemetryfrom Feb 17, 2026
Merged
Conversation
patriknw
reviewed
Feb 12, 2026
| typeName: String): Unit = | ||
| instrumentations.foreach(_.incrementShardRegionBufferSize(selfAddress, shardRegionActor, typeName)) | ||
|
|
||
| override def beginnShardHandoff(selfAddress: Address, shardCoordinatorActor: ActorRef, typeName: String): Unit = |
| import Internal._ | ||
|
|
||
| private val instrumentation = ClusterShardingInstrumentationProvider.get(context.system).instrumentation | ||
| val cluster = Cluster(context.system) |
| private val instrumentation = ClusterShardingInstrumentationProvider.get(context.system).instrumentation | ||
| val cluster = Cluster(context.system) | ||
|
|
||
| instrumentation.beginnShardHandoff(cluster.selfAddress, self, typeName) |
Contributor
There was a problem hiding this comment.
might be good to include shard since this is a handoff for a specific typeName and shard
| if (ok) { | ||
| instrumentation.finishedShardHandoffOk(cluster.selfAddress, self, typeName) | ||
| } else { | ||
| instrumentation.finishedShardHandoffNotOk(cluster.selfAddress, self, typeName) |
Contributor
There was a problem hiding this comment.
could consider having only finishedShardHandoff with ok: Boolean as parameter?
| } | ||
|
|
||
| override def beginnShardHandoff(selfAddress: Address, shardCoordinatorActor: ActorRef, typeName: String): Unit = { | ||
| println("ok jea >?>>") |
| selfAddress: Address, | ||
| shardRegionActor: ActorRef, | ||
| typeName: String): Unit = { | ||
| counter.incrementAndGet() |
Contributor
There was a problem hiding this comment.
perhaps counter should have a more specific name now?
| override def finishedShardHandoffOk(selfAddress: Address, shardCoordinatorActor: ActorRef, typeName: String): Unit = { | ||
| println("ok jea >?>> FINNNNNNN") | ||
| val currentValue = shardHandoffDuration.get() | ||
| shardHandoffDuration.set(System.currentTimeMillis() - currentValue) |
Contributor
There was a problem hiding this comment.
similar comment here, avoid clock?
sebastian-alfers
force-pushed
the
sharding-telemetry
branch
from
f44207d to
0fbb370
Compare
sebastian-alfers
force-pushed
the
shard-handoff-latency
branch
from
cead4d7 to
4f3f356
Compare
johanandren
reviewed
Feb 12, 2026
| selfAddress: Address, | ||
| shardCoordinatorActor: ActorRef, | ||
| typeName: String, | ||
| shard: String): Unit = beginShardHandoffDurationCounter.incrementAndGet() |
Contributor
There was a problem hiding this comment.
That's not latency though, it is a counter. Latency would be a timestamp at begin to and then one at finish to calculate the time it took.
Contributor
There was a problem hiding this comment.
Ah, it is just the test counting NVM!
Contributor
Author
There was a problem hiding this comment.
No, thanks for pointing out. I now avoid the term "latency" at all, as you are correct here!
sebastian-alfers
changed the title
johanandren
reviewed
Feb 12, 2026
...-sharding/src/main/scala/akka/cluster/sharding/internal/ClusterShardingInstrumentation.scala
Outdated
Show resolved
Hide resolved
johanandren
approved these changes
Feb 12, 2026
sebastian-alfers
force-pushed
the
sharding-telemetry
branch
from
9c2e143 to
b0272ea
Compare
sebastian-alfers
force-pushed
the
shard-handoff-latency
branch
from
9b2a842 to
e5d7987
Compare
johanandren
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.