Skip to content

cte: fix TtribCte#151

Merged
rvalyi merged 1 commit intoakretion:masterfrom
Escodoo:fix-namespace-cte
Mar 30, 2026
Merged

cte: fix TtribCte#151
rvalyi merged 1 commit intoakretion:masterfrom
Escodoo:fix-namespace-cte

Conversation

@CristianoMafraJunior
Copy link
Copy Markdown
Contributor

@CristianoMafraJunior CristianoMafraJunior commented Mar 25, 2026

Acabei identificando que a tag IBSCBS está sendo exportado com os atributos:

Com essa correção passando o TtribCte não cria mais esses namespaces

@CristianoMafraJunior CristianoMafraJunior marked this pull request as draft March 25, 2026 16:17
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.39%. Comparing base (87eac53) to head (4552772).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          10       10           
  Lines         357      357           
  Branches       30       30           
=======================================
  Hits          337      337           
  Misses         10       10           
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CristianoMafraJunior CristianoMafraJunior marked this pull request as ready for review March 25, 2026 16:47
@CristianoMafraJunior CristianoMafraJunior mentioned this pull request Mar 25, 2026
Merged
@rvalyi
Copy link
Copy Markdown
Member

rvalyi commented Mar 25, 2026 •
edited
Loading

Valeu @CristianoMafraJunior isso parece o mesmo tipo de bug que tivemos com o IBS/CBS com a NFe. Eu acabei ajustando as pressas para a NFe , mas eu acredito que se trata de um bug no proprio xsdata... Vou olhar melhor e retornar. Na pior a gente avança com esse patch pequeno por enquanto...

@rvalyi
Copy link
Copy Markdown
Member

rvalyi commented Mar 30, 2026

Valeu @CristianoMafraJunior . Vou mesclar isso e adicionar um teste por cima para ter certeza que o patch ta aplicado ou que o bug no xsdata foi resolvido

@rvalyi rvalyi merged commit 696524a into akretion:master Mar 30, 2026
10 checks passed
rvalyi added a commit that referenced this pull request Mar 30, 2026
@rvalyi
[TEST] Add test for CTe IBSCBS xsdata patch
5612721 
Add test_patched_xsdata_for_ibscsb to verify that the IBSCBS field
in CTe bindings uses TtribCte type instead of str.

This test ensures the namespace fix from PR #151 is properly applied
to all three CTe document types (Tcte, TcteOs, TcteSimp).

Refs: #151
@rvalyi rvalyi mentioned this pull request Mar 30, 2026
Merged
rvalyi added a commit that referenced this pull request Mar 30, 2026
@rvalyi
[TEST] Add test for CTe IBSCBS xsdata patch
f1e0825 
Add test_patched_xsdata_for_ibscsb to verify that the IBSCBS field
in CTe bindings uses TtribCte type instead of str.

This test ensures the namespace fix from PR #151 is properly applied
to all three CTe document types (Tcte, TcteOs, TcteSimp).

Refs: #151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CristianoMafraJunior @rvalyi