Skip to content

Conversation

@byquanton
Copy link
Collaborator

@byquanton byquanton commented Jan 14, 2025

This PR removes the current online detection and replaces it with a callback that shows the user when a connection to a server couldn't be made.
Would fix the following issue: #1489

Things left to-do in the current implementation:

  • Add sync_failed calls to Todoist
  • Update translations/Finalize the new text
  • Make it possible to add to-dos offline -> Create a new PR for this

If you have any feedback about this PR, please let me know.

@byquanton byquanton force-pushed the rewrite/offline-detection branch from de501fb to 388c323 Compare January 15, 2025 20:39
@byquanton
Copy link
Collaborator Author

New To-Do: Make it possible to add a To-Do while the server is offline. Maybe add an icon behind tasks when changes aren't synchronized yet
image

@Fadikkop
Copy link

The Notifications of the Flatpak are per default denied.

@byquanton byquanton changed the title WIP: Rewrite Offline Mode Rewrite Offline Mode Jan 18, 2025
@byquanton byquanton marked this pull request as ready for review January 18, 2025 16:28
@byquanton byquanton requested a review from alainm23 January 18, 2025 16:29
@alainm23 alainm23 merged commit 41d18f8 into alainm23:master Jan 18, 2025
2 checks passed
@alainm23
Copy link
Owner

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants