Skip to content

Rewrite Offline Mode #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 18, 2025
Merged

Rewrite Offline Mode #1511

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae4c0f0
Rewrite offline detection to check the connectivity per connected int…
byquanton Jan 14, 2025
388c323
Drop NetworkMonitor class, because it is no longer needed
byquanton Jan 15, 2025
e1dc284
Add sync_failed call to Todoist
byquanton Jan 15, 2025
2254789
Fix Code Format
byquanton Jan 15, 2025
f267134
Make the SyncButton clickable even when it currently shows an error
byquanton Jan 15, 2025
0890fca
Update planify pot and de.po
byquanton Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/Services/Todoist.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,8 @@ public class Services.Todoist : GLib.Object {
yield queue (source);
}
} catch (Error e) {
debug ("Failed to sync: "+e.message);
source.sync_failed();
debug ("Failed to sync: " + e.message);
source.sync_failed ();
}

source.last_sync = new GLib.DateTime.now_local ().to_string ();
Expand Down
12 changes: 8 additions & 4 deletions src/Widgets/SyncButton.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,17 @@ public class Widgets.SyncButton : Adw.Bin {
css_classes = { "flat", "header-item-button", "dim-label" }
};

var error_image = new Gtk.Image () {
gicon = new ThemedIcon ("dialog-warning-symbolic"),
pixel_size = 13
var error_button = new Gtk.Button.from_icon_name ("dialog-warning-symbolic") {
valign = Gtk.Align.CENTER,
css_classes = { "flat", "header-item-button", "dim-label" }
};

stack = new Gtk.Stack () {
transition_type = Gtk.StackTransitionType.CROSSFADE
};

stack.add_named (sync_button, "sync");
stack.add_named (error_image, "error");
stack.add_named (error_button, "error");

main_revealer = new Gtk.Revealer () {
transition_type = Gtk.RevealerTransitionType.CROSSFADE,
Expand All @@ -64,6 +64,10 @@ public class Widgets.SyncButton : Adw.Bin {
sync_button.clicked.connect (() => {
clicked ();
});

error_button.clicked.connect (() => {
clicked ();
});
}

public void sync_started () {
Expand Down
Loading