Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the testing documentation for the apywire project by adding comprehensive testing conventions to both docs/development.md and AGENTS.md. The changes provide clear guidance on best practices for testing compiled code, type safety, module mocking, and test naming.
Key Changes
- Added detailed testing conventions section to
docs/development.mdwith code examples - Added concise testing conventions reference to
AGENTS.md - Documented patterns for testing compiled code, Protocol usage, module mocking, and test naming
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/development.md | Added comprehensive "Testing Conventions" subsection with detailed explanations and code examples for compiled code testing, type safety, coverage goals, naming patterns, and module mocking |
| AGENTS.md | Added concise "Testing Conventions" section with quick reference for compiled objects, type safety, module mocking, and async tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.