[GraphEditor] Node: Check if unexposed ListAttributes contain links
#2578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If unexposed attributes (ie. attributes that are located in the lower side of a node, and hidden by default) are connected, they are meant to remain visible even if the lower part of that node is hidden. This was working fine for any attribute that was not a `ListAttribute`, as the check was made on whether the attribute's value was a link to another attribute. For `ListAttributes`, whose value is actually a list of values, this was not working as nested links were not checked. Instead of relying on the `isLink` property, we now use `isLinkNested`: for regular attributes, this is equivalent to using `isLink`, but for `ListAttributes`, the full list of values will be checked.
cbentejac
force-pushed
the
fix/unexposedEdges
branch
from
40c50b1 to
248229e
Compare
Member
|
We need to have the isLinkNested property on GroupAttributes too. |
fabiencastan
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If unexposed attributes (ie. attributes that are located in the lower side of a node, and hidden by default) are connected, they are meant to remain visible even if the lower part of that node is hidden.
This was working fine for any attribute that was not a
ListAttribute, as the check was made on whether the attribute's value was a link to another attribute. ForListAttributes, whose value is actually a list of values, this was not working as nested links were not checked.Instead of relying on the
isLinkproperty, we now useisLinkNested: for regular attributes, this is equivalent to usingisLink, but forListAttributes, the full list of values will be checked.