New Plugin Architecture for Node Registration

[cbentejac]

Description

This PR adds the support for plugins in Meshroom, building on top of #2703.

A Plugin is a collection of at least one NodePlugin, which contains the description of a node, and can be associated to templates. Plugins can be loaded and unloaded with the NodePluginManager, which is in charge of the registration and unregistration of all NodePlugins (a node cannot be instantiated until its NodePlugin has been registered).

All collections of nodes are now considered as plugins, may they be provided through the MESHROOM_NODES_PATH or through the MESHROOM_PLUGINS_PATH environment variables. In the case of MESHROOM_NODES_PATH, a Python module containing node descriptions is expected. For MESHROOM_PLUGINS_PATH, it is expected that the nodes are contained within a Python module that is itself located in a meshroom folder.

Features list

• Add a "plugins" core module containing new classes: Plugin, NodePlugin, NodePluginManager;
• Fully manage the loading and registration of nodes through the NodePluginManager;
• Add unit tests for the newly added classes.

Implementations remarks

Currently, the whole process of going through folders in search of Python packages remains in the __init__.py of the core module. This is because the method that is used to find files containing nodes is the same as the one used to discover submitters. Submitters are, for now, not included in the "plugins" module and are handled as they were previously.

[Copilot]

Pull Request Overview

This PR implements support for plugins in Meshroom by introducing a new “plugins” core module with Plugin, NodePlugin, and NodePluginManager classes, refactoring node registration and discovery to use the new pluginManager, and updating tests accordingly.

• Refactor of node registration from nodesDesc to pluginManager.
• Updates of unit tests and integration of plugin-based node discovery.
• Addition of new plugin and node files for PluginA and PluginB.

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.

File	Description
tests/test_compatibility.py	Refactored node registration and unregistration to use pluginManager.
tests/test_attributeChoiceParam.py	Updated node registration and tear down to use NodePlugin and pluginManager.
tests/plugins/meshroom/pluginB/PluginBNodeB.py	Added new plugin node with potential type mismatch in IntParam default value.
Remaining files	Various code refactoring and formatting changes to switch from nodesDesc to pluginManager integration.

[codecov]

Codecov Report

Attention: Patch coverage is 91.00775% with 58 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (99a6dc0) to head (d3738fb).
Report is 45 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
meshroom/core/plugins.py	87.64%	22 Missing ⚠️
meshroom/core/__init__.py	73.33%	16 Missing ⚠️
meshroom/core/graph.py	31.25%	11 Missing ⚠️
meshroom/core/attribute.py	87.27%	7 Missing ⚠️
meshroom/common/qt.py	50.00%	1 Missing ⚠️
meshroom/core/nodeFactory.py	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2733      +/-   ##
===========================================
+ Coverage    77.15%   78.46%   +1.30%     
===========================================
  Files           41       47       +6     
  Lines         6167     6542     +375     
===========================================
+ Hits          4758     5133     +375     
  Misses        1409     1409              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.