[bin] meshroom_batch: Add support for setting multiple Publish nodes' output folders
#2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the path that is provided to the `output` attribute does not exist, it should be created by the node. `os.mkdir` only creates one level of directory instead of creating all the intermediate folders, thus raising an error if there are several intermediate folders that do not exist.
`Publish` node names can be specified with the `-o` option to set these nodes' output folders individually. If node names are not specified, all the `Publish` nodes are set with the same output folder (as was the case until this commit).
cbentejac
requested review from
Alxiice,
fabiencastan and
servantftransperfect
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2867 +/- ##
========================================
Coverage 77.46% 77.46%
========================================
Files 48 48
Lines 6735 6735
========================================
Hits 5217 5217
Misses 1518 1518 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+260
to
+261
| if globalPublishPath == "": # Fallback in case some nodes would have no path | ||
| globalPublishPath = value |
Member
There was a problem hiding this comment.
I would remove these 2 lines for clarity/simplicity of the rules.
Contributor
Author
There was a problem hiding this comment.
If some nodes don't have a specified path and there's no "global path", should we then throw an error?
Alxiice
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the support for multiple
Publishnodes with different output folders inmeshroom_batch. Prior to it, a graph could have severalPublishnodes, but only one path could be provided to the--outputoption, meaning all the nodes were writing their outputs in the same folder.With this PR, specific
Publishnodes can have their output folder set using the syntaxNAME=FOLDER(e.g-o Publish_1=/path/to/output/folder). Different cases are covered:Publishnodes are specified individually (-o Publish_1=/path/to/folder1 Publish_2=/path/to/folder2): they will be set with their provided output folders.Publishnode has a specified path (-o /path/to/output/folder): all thePublishnodes will be set with the same provided value (this was the behaviour up until this PR).Publishnodes are specified individually, but some are not (-o Publish_1=/path/to/folder1): all thePublishnodes that do not have a specified output folder will use the first specified node's (here,/path/to/folder1).Publishnodes are specified individually, and a path that is not associated to any node is also provided (-o Publish_1=/path/to/folder1 /path/to/output): the specified nodes will be set with their own output folders, all the other ones will use the remaining path.Publishnodes have a specified path, but several paths are provided (-o /path/to/folder1 /path/to/folder2): all thePublishnodes will be set with the last path that was provided (here/path/to/folder2).Additionally, the
Publishnode is slightly modified to replaceos.mkdirwithos.makedirswhen the provided output folder does not exist and needs to be created. With that change, if the intermediate folders also do not exist, they will be created instead of an error being raised.