Skip to content

Conversation

@fabiencastan
Copy link
Member

This pull request makes minor updates to how environment variables and user selection are handled in the simpleFarmSubmitter.py file to improve flexibility and robustness.

  • Environment variable handling:

    • Added support for passing the PROD and PROD_ROOT environment variables to the submitter's environment if they are present.
  • User selection logic:

    • Changed the order of precedence for selecting the user: now prioritizes the FARM_USER environment variable over USER and the system's default user.

@fabiencastan fabiencastan added this to the Meshroom 2026.1.0 milestone Sep 20, 2025
@codecov
Copy link

codecov bot commented Sep 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.56%. Comparing base (391afc7) to head (33bc3ae).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2899   +/-   ##
========================================
  Coverage    79.56%   79.56%           
========================================
  Files           51       51           
  Lines         6977     6977           
========================================
  Hits          5551     5551           
  Misses        1426     1426           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabiencastan fabiencastan merged commit 0438f49 into develop Sep 20, 2025
5 checks passed
@fabiencastan fabiencastan deleted the dev/submitterEnv branch September 20, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants