Skip to content

[core] attribute: warning on failure inside node callables #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

[core] attribute: warning on failure inside node callables #2903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions meshroom/core/attribute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,7 @@ def getDefaultValue(self):
return self._desc.value(self)
except Exception as e:
if not self.node.isCompatibilityNode:
# Log message only if we are not in compatibility mode
logging.warning("Failed to evaluate default value (node lambda) for attribute '{}': {}".
format(self.name, e))
logging.warning(f"Failed to evaluate 'defaultValue' (node lambda) for attribute '{self.fullName}': {e}")
return None
# Need to force a copy, for the case where the value is a list
# (avoid reference to the desc value)
Expand Down Expand Up @@ -284,7 +282,9 @@ def _isValid(self):
if callable(self._desc.validValue):
try:
return self._desc.validValue(self.node)
except Exception:
except Exception as e:
if not self.node.isCompatibilityNode:
logging.warning(f"Failed to evaluate 'isValid' (node lambda) for attribute '{self.fullName}': {e}")
return True
return True

Expand Down Expand Up @@ -345,8 +345,9 @@ def _getEnabled(self) -> bool:
if callable(self._desc.enabled):
try:
return self._desc.enabled(self.node)
except Exception:
# Node implementation may fail due to version mismatch
except Exception as e:
if not self.node.isCompatibilityNode:
logging.warning(f"Failed to evaluate 'enabled' (node lambda) for attribute '{self.fullName}': {e}")
return True
return self._desc.enabled

Expand Down
Loading