Skip to content

Conversation

@fabiencastan
Copy link
Member

When creating new nodes, it is difficult to debug if errors inside node's callables are ignored without any warning.

@fabiencastan fabiencastan added this to the Meshroom 2026.1.0 milestone Sep 23, 2025
@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.50%. Comparing base (b21ca05) to head (af2940f).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/attribute.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2903      +/-   ##
===========================================
- Coverage    79.55%   79.50%   -0.05%     
===========================================
  Files           51       51              
  Lines         6974     6978       +4     
===========================================
  Hits          5548     5548              
- Misses        1426     1430       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac merged commit f3e3fa8 into develop Sep 24, 2025
3 of 5 checks passed
@cbentejac cbentejac deleted the dev/callableWarnings branch September 24, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants