Skip to content

Fix local versioning to match PyPA standards and modern setuptools requirements [UPDATE] #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2025
Merged

Fix local versioning to match PyPA standards and modern setuptools requirements [UPDATE] #2904

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adbdd3b
fixed local version semantics to match PyPA standards
MeirArani Jul 17, 2025
0b810f9
Removed redundant develop tag
fabiencastan Sep 23, 2025
f816c8e
Remove reference to ION
fabiencastan Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions meshroom/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import os
import sys


class VersionStatus(Enum):
release = 1
develop = 2
Expand All @@ -15,7 +14,7 @@ class VersionStatus(Enum):
__version_status__ = VersionStatus.develop

if __version_status__ is VersionStatus.develop:
__version__ += "-" + __version_status__.name
__version__ += "+" + __version_status__.name

__version_label__ = __version__
# Modify version label if we are in a development phase.
Expand All @@ -29,15 +28,10 @@ class VersionStatus(Enum):
data = headFile.readlines()
branchName = data[0].split('/')[-1].strip()
__version_label__ += " branch=" + branchName
else:
# Add a generic default label "develop"
__version_label__ += "-" + __version_status__.name

# Allow override from env variable
if "REZ_MESHROOM_VERSION" in os.environ:
__version_label__ += " package=" + os.environ.get("REZ_MESHROOM_VERSION")
elif "ION_MESHROOM_VERSION" in os.environ:
__version_label__ += " container=" + os.environ.get("ION_MESHROOM_VERSION")


# Internal imports after the definition of the version
Expand Down
Loading