Skip to content

Conversation

@cbentejac
Copy link
Contributor

Description

This PR makes a minor fix to the construction of the rezBin path in the rezWrapCommand function in meshroom/submitters/tractorSubmitter.py. The change corrects the path joining logic to prevent an incorrect file path.

  • Fixed the path construction for rezBin by removing the leading slash from "/bin/rez" and changing it to "bin/rez", ensuring os.path.join produces the correct path. Otherwise, rezBin is erroneously set to "/bin/rez".

Removing the "/" of "bin/rez" allows the `join` to work effectively.
If it is kept, `rezBin` is erroneously set to `/bin/rez`.
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.86%. Comparing base (6594215) to head (ee678a8).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2928   +/-   ##
========================================
  Coverage    80.86%   80.86%           
========================================
  Files           57       57           
  Lines         7792     7792           
========================================
  Hits          6301     6301           
  Misses        1491     1491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabiencastan fabiencastan merged commit 17b411c into develop Oct 28, 2025
4 checks passed
@fabiencastan fabiencastan deleted the fix/submitterTractor branch October 28, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants